You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/06/30 06:11:00 UTC
[jira] [Commented] (YARN-10320) Replace FSDataInputStream#read with
readFully in Log Aggregation
[ https://issues.apache.org/jira/browse/YARN-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148335#comment-17148335 ]
Hadoop QA commented on YARN-10320:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 13s{color} | {color:red} YARN-10320 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-10320 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13006724/YARN-10320-001.patch |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/26233/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Replace FSDataInputStream#read with readFully in Log Aggregation
> ----------------------------------------------------------------
>
> Key: YARN-10320
> URL: https://issues.apache.org/jira/browse/YARN-10320
> Project: Hadoop YARN
> Issue Type: Bug
> Components: log-aggregation
> Affects Versions: 3.3.0
> Reporter: Prabhu Joseph
> Assignee: Tanu Ajmera
> Priority: Major
> Attachments: YARN-10320-001.patch
>
>
> Have observed Log Aggregation code has used FSDataInputStream#read instead of readFully in multiple places like below. One of the place is fixed by YARN-8106.
> This Jira targets to fix at all other places.
> LogAggregationIndexedFileController#loadUUIDFromLogFile
> {code}
> byte[] b = new byte[uuid.length];
> int actual = fsDataInputStream.read(b);
> if (actual != uuid.length || Arrays.equals(b, uuid)) {
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org