[GitHub] [orc] dongjoon-hyun commented on a change in pull request #736: ORC-831: Do Not Copy String When Flushing Dictionary

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665715334



##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -44,9 +44,22 @@
 
   /**
    * Given the position index, return the original string before being encoded.
+   * The value of the Text in the Dictionary is copied into {@code result}.
+   *
+   * @param result the holder to copy the dictionary text into
+   * @param position the position where the key was added
    */
   void getText(Text result, int position);
 
+  /**
+   * Given the position index, write the original string, before being encoded,
+   * to the OutputStream.
+   *
+   * @return the number of byte written to the stream

Review comment:
       Shall we add `@param` for `out` and `position`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org