You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:01:39 UTC
Review Request 70093: Added license header to some Python source
files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70093/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, haosdent huang, and Steve Niemitz.
Repository: mesos
Description
-------
Added license header to some Python source files.
Diffs
-----
mpi/mpiexec-mesos.py d86c85bd68e75f2ddd190254da4f520e9f126d6f
src/python/cli/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
src/python/executor/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
src/python/interface/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
src/python/interface/src/mesos/v1/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
src/python/interface/src/mesos/v1/interface/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
src/python/native/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
src/python/protocol/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
src/python/scheduler/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
src/python/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
Diff: https://reviews.apache.org/r/70093/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70093: Added license header to some Python source
files.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70093/#review213487
-----------------------------------------------------------
Fix it, then Ship it!
src/python/scheduler/src/mesos/__init__.py
Lines 17-32 (patched)
<https://reviews.apache.org/r/70093/#comment299421>
Why doubled?
- Alexander Rukletsov
On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70093/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:01 a.m.)
>
>
> Review request for mesos, Armand Grillet, haosdent huang, and Steve Niemitz.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added license header to some Python source files.
>
>
> Diffs
> -----
>
> mpi/mpiexec-mesos.py d86c85bd68e75f2ddd190254da4f520e9f126d6f
> src/python/cli/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
> src/python/executor/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
> src/python/interface/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
> src/python/interface/src/mesos/v1/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> src/python/interface/src/mesos/v1/interface/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> src/python/native/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
> src/python/protocol/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
> src/python/scheduler/src/mesos/__init__.py 3fcba01e3801cab7b21cbfc32972e9ab2810ddda
> src/python/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
>
>
> Diff: https://reviews.apache.org/r/70093/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>