You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2016/11/17 06:46:11 UTC
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1649
[ZEPPELIN-1678] Improve main page notebook filter style
### What is this PR for?
Current notebook filter has different style compared to other filters used in zeppelin. So users can feel mismatch from the main page. (I attached PNG)
<img width="313" alt="old_1" src="https://cloud.githubusercontent.com/assets/4968473/20378935/a88a1e2e-acdc-11e6-92eb-502a0fedaca7.png">
<img width="321" alt="old_2" src="https://cloud.githubusercontent.com/assets/4968473/20378937/aa14387e-acdc-11e6-87f1-c92e5ac0d1e5.png">
Let me add some comments already included in the commit for description.
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
### What type of PR is it?
[Improvement ]
### What is the Jira issue?
[ZEPPELIN-1678](https://issues.apache.org/jira/browse/ZEPPELIN-1678)
### How should this be tested?
See main page and navbar :)
### Screenshots (if appropriate)
After fixed (chrome, firefox, safari)
<img width="324" alt="chrome" src="https://cloud.githubusercontent.com/assets/4968473/20378955/c8c60f2c-acdc-11e6-86c2-5b1db11332a0.png">
<img width="274" alt="firefox" src="https://cloud.githubusercontent.com/assets/4968473/20378956/c9fc60bc-acdc-11e6-883b-2cf8b730b037.png">
<img width="271" alt="safari" src="https://cloud.githubusercontent.com/assets/4968473/20378958/cd9aa9d6-acdc-11e6-85c0-e3504d72d5e1.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older version s - NO?
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/input-style-for-note-name-query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1649
----
commit 6fc244932f5353c34bb55a1af4a9b42c23292714
Author: 1ambda <1a...@gmail.com>
Date: 2016-11-17T06:40:54Z
fix: Set notebook filter font-style
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1649
@1ambda I just built Zeppelin from master branch and took screenshots :)
### Chrome secret tab:
### Safari:
### Firefox:
It didn't happen to me, but I think there are other users suffering the same issue with you since it happened to you \U0001f604
So, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1649
### OS:
### Chrome:
54.0.2840.98 (64-bit)
Maybe because of macOS version :)
(Please don't upgrade to Sierra)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1649
[ZEPPELIN-1678] Improve main page notebook filter style
### What is this PR for?
Current notebook filter has different style compared to other filters used in zeppelin. So users can feel mismatch from the main page. (I attached PNG)
<img width="313" alt="old_1" src="https://cloud.githubusercontent.com/assets/4968473/20378935/a88a1e2e-acdc-11e6-92eb-502a0fedaca7.png">
<img width="321" alt="old_2" src="https://cloud.githubusercontent.com/assets/4968473/20378937/aa14387e-acdc-11e6-87f1-c92e5ac0d1e5.png">
<br/>
<br/>
Let me add some comments already included in the commit for description.
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
### What type of PR is it?
[Improvement ]
### What is the Jira issue?
[ZEPPELIN-1678](https://issues.apache.org/jira/browse/ZEPPELIN-1678)
### How should this be tested?
See main page and navbar :)
### Screenshots (if appropriate)
After fixed (chrome, firefox, safari)
<img width="324" alt="chrome" src="https://cloud.githubusercontent.com/assets/4968473/20378955/c8c60f2c-acdc-11e6-86c2-5b1db11332a0.png">
<img width="274" alt="firefox" src="https://cloud.githubusercontent.com/assets/4968473/20378956/c9fc60bc-acdc-11e6-883b-2cf8b730b037.png">
<img width="271" alt="safari" src="https://cloud.githubusercontent.com/assets/4968473/20378958/cd9aa9d6-acdc-11e6-85c0-e3504d72d5e1.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older version s - NO?
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/input-style-for-note-name-query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1649
----
commit 6fc244932f5353c34bb55a1af4a9b42c23292714
Author: 1ambda <1a...@gmail.com>
Date: 2016-11-17T06:40:54Z
fix: Set notebook filter font-style
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1649
[ZEPPELIN-1678] Improve main page notebook filter style
### What is this PR for?
Current notebook filter has different style compared to other filters used in zeppelin. So users can feel mismatch from the main page. (I attached PNG)
<img width="313" alt="old_1" src="https://cloud.githubusercontent.com/assets/4968473/20378935/a88a1e2e-acdc-11e6-92eb-502a0fedaca7.png">
<img width="321" alt="old_2" src="https://cloud.githubusercontent.com/assets/4968473/20378937/aa14387e-acdc-11e6-87f1-c92e5ac0d1e5.png">
<br/>
<br/>
Let me add some comments already included in the commit for description.
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
### What type of PR is it?
[Improvement ]
### What is the Jira issue?
[ZEPPELIN-1678](https://issues.apache.org/jira/browse/ZEPPELIN-1678)
### How should this be tested?
See main page and navbar :)
### Screenshots (if appropriate)
After fixed (chrome, firefox, safari)
<img width="324" alt="chrome" src="https://cloud.githubusercontent.com/assets/4968473/20378955/c8c60f2c-acdc-11e6-86c2-5b1db11332a0.png">
<img width="274" alt="firefox" src="https://cloud.githubusercontent.com/assets/4968473/20378956/c9fc60bc-acdc-11e6-883b-2cf8b730b037.png">
<img width="271" alt="safari" src="https://cloud.githubusercontent.com/assets/4968473/20378958/cd9aa9d6-acdc-11e6-85c0-e3504d72d5e1.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older version s - NO?
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/input-style-for-note-name-query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1649
----
commit 6fc244932f5353c34bb55a1af4a9b42c23292714
Author: 1ambda <1a...@gmail.com>
Date: 2016-11-17T06:40:54Z
fix: Set notebook filter font-style
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1649
@1ambda Nice catch!
Does that happen in IE? Because my Zeppelin didn't happen that way :)
I use Macbook Pro and tested on Chrome, Safari, and Firefox.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1649
CI failed but it doesn't related with this PR
- https://api.travis-ci.org/jobs/176613823/log.txt?deansi=true (NPE)
- https://api.travis-ci.org/jobs/176613828/log.txt?deansi=true (`ParagraphActionsIT.testEditOnDoubleClick:443 � ElementNotVisible Element is no...`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1649
@tae-jun Hi!
Could you share screenshots (chrome secret tab, safari, firefox)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/1649
[ZEPPELIN-1678] Improve main page notebook filter style
### What is this PR for?
Current notebook filter has different style compared to other filters used in zeppelin. So users can feel mismatch from the main page. (I attached PNG)
<img width="313" alt="old_1" src="https://cloud.githubusercontent.com/assets/4968473/20378935/a88a1e2e-acdc-11e6-92eb-502a0fedaca7.png">
<img width="321" alt="old_2" src="https://cloud.githubusercontent.com/assets/4968473/20378937/aa14387e-acdc-11e6-87f1-c92e5ac0d1e5.png">
<br/>
<br/>
Let me add some comments already included in the commit for description.
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
### What type of PR is it?
[Improvement ]
### What is the Jira issue?
[ZEPPELIN-1678](https://issues.apache.org/jira/browse/ZEPPELIN-1678)
### How should this be tested?
See main page and navbar :)
### Screenshots (if appropriate)
After fixed (chrome, firefox, safari)
<img width="324" alt="chrome" src="https://cloud.githubusercontent.com/assets/4968473/20378955/c8c60f2c-acdc-11e6-86c2-5b1db11332a0.png">
<img width="274" alt="firefox" src="https://cloud.githubusercontent.com/assets/4968473/20378956/c9fc60bc-acdc-11e6-883b-2cf8b730b037.png">
<img width="271" alt="safari" src="https://cloud.githubusercontent.com/assets/4968473/20378958/cd9aa9d6-acdc-11e6-85c0-e3504d72d5e1.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older version s - NO?
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/input-style-for-note-name-query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1649
----
commit 6fc244932f5353c34bb55a1af4a9b42c23292714
Author: 1ambda <1a...@gmail.com>
Date: 2016-11-17T06:40:54Z
fix: Set notebook filter font-style
- Use common font-style which is widely used in zeppelin
- Modify inlined font css while removing some useless properties which have default value
`font-style`, `font-variant`, `font-weight` default value is already `normal`
see http://www.w3schools.com/csSref/pr_font_font.asp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1649: [ZEPPELIN-1678] Improve main page notebook filt...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/1649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1649
Nice improvement @1ambda
LGTM and merge to master if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1649
@tae-jun Thanks for sharing.
Some people might have same problems because `note-name-query` class has `FontAwesome` font-style only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---