You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by dpolivy <gi...@git.apache.org> on 2015/05/08 01:37:54 UTC

[GitHub] cordova-plugin-splashscreen pull request: CB-8988: Fix rotation on...

GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/46

    CB-8988: Fix rotation on iOS/iPad

    The viewController.interfaceOrientation passed to getImageName has not
    yet been updated with the new orientation, even when the frame/bounds
    change event has fired. Thus, the plugin never actually loads the
    correct image for the new orientation. Instead, it poorly scales the
    existing image.
    
    This fix uses the statusBarOrientation property of the UIApplication
    object to detect the actual orientation, and correctly load the right
    image.
    
    Fixes https://issues.apache.org/jira/browse/CB-8988

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-plugin-splashscreen CB8988

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 4df490b4d935ffd43904dda1726a790372c64d92
Author: Dan Polivy <da...@cellartracker.com>
Date:   2015-05-07T23:37:02Z

    CB-8988: Fix rotation on iOS/iPad
    
    The viewController.interfaceOrientation passed to getImageName has not
    yet been updated with the new orientation, even when the frame/bounds
    change event has fired. Thus, the plugin never actually loads the
    correct image for the new orientation. Instead, it poorly scales the
    existing image.
    
    This fix uses the statusBarOrientation property of the UIApplication
    object to detect the actual orientation, and correctly load the right
    image.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-8988: Fix rotation on...

Posted by shazron <gi...@git.apache.org>.

Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100305790
  
    Thanks for the PR Dan -- I'm away, will take a look Monday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-8988: Fix rotation on...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-8988: Fix rotation on...

Posted by dpolivy <gi...@git.apache.org>.

Github user dpolivy commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100047179
  
    @shazron Can you please review & merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org