You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/04/24 11:23:01 UTC
Re: Review Request 58348: Introduced a filter for test cases that need
thread-safety.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58348/
-----------------------------------------------------------
(Updated April 24, 2017, 1:23 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Use a test filter instead of asserts.
Summary (updated)
-----------------
Introduced a filter for test cases that need thread-safety.
Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193
Repository: mesos
Description (updated)
-------
Instead of using asserts that would fail a test at runtime when
thread-safety of the test environment isn't given, these tests are now
filtered out before running the tests.
Diffs (updated)
-----
src/tests/environment.hpp 6d9a2bd451c15bb73b8018a6ad5ff04655bbec3b
src/tests/environment.cpp 3d2d8f177b2793f06d6adecfd110819bb7bbb86d
src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
Diff: https://reviews.apache.org/r/58348/diff/2/
Changes: https://reviews.apache.org/r/58348/diff/1-2/
Testing
-------
mesos-tests (using automake and CMake with macOS, Linux and Windows)
Thanks,
Jan Schlicht
Re: Review Request 58348: Introduced a filter for test cases that need
thread-safety.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58348/#review172794
-----------------------------------------------------------
This RR does not seem to do what the RR's summary/description says it does. Can you clarify?
src/tests/environment.cpp
Line 719 (original), 718 (patched)
<https://reviews.apache.org/r/58348/#comment245841>
Should this comment be removed/updated?
- Neil Conway
On April 24, 2017, 11:23 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58348/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 11:23 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7193
> https://issues.apache.org/jira/browse/MESOS-7193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of using asserts that would fail a test at runtime when
> thread-safety of the test environment isn't given, these tests are now
> filtered out before running the tests.
>
>
> Diffs
> -----
>
> src/tests/environment.hpp 6d9a2bd451c15bb73b8018a6ad5ff04655bbec3b
> src/tests/environment.cpp 3d2d8f177b2793f06d6adecfd110819bb7bbb86d
> src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
>
>
> Diff: https://reviews.apache.org/r/58348/diff/2/
>
>
> Testing
> -------
>
> mesos-tests (using automake and CMake with macOS, Linux and Windows)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58348/#review175178
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On May 15, 2017, 10:24 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58348/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:24 a.m.)
>
>
> Review request for mesos, Neil Conway and Till Toenshoff.
>
>
> Bugs: MESOS-7193
> https://issues.apache.org/jira/browse/MESOS-7193
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed use of 'GTEST_IS_THREADSAFE'.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 3d2d8f177b2793f06d6adecfd110819bb7bbb86d
> src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
>
>
> Diff: https://reviews.apache.org/r/58348/diff/3/
>
>
> Testing
> -------
>
> make check (using automake and CMake with macOS, Linux and Windows)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 58348: Fixed use of 'GTEST_IS_THREADSAFE'.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58348/
-----------------------------------------------------------
(Updated May 15, 2017, 12:24 p.m.)
Review request for mesos, Neil Conway and Till Toenshoff.
Changes
-------
Rebased.
Summary (updated)
-----------------
Fixed use of 'GTEST_IS_THREADSAFE'.
Bugs: MESOS-7193
https://issues.apache.org/jira/browse/MESOS-7193
Repository: mesos
Description (updated)
-------
Fixed use of 'GTEST_IS_THREADSAFE'.
Diffs (updated)
-----
src/tests/environment.cpp 3d2d8f177b2793f06d6adecfd110819bb7bbb86d
src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
Diff: https://reviews.apache.org/r/58348/diff/3/
Changes: https://reviews.apache.org/r/58348/diff/2-3/
Testing (updated)
-------
make check (using automake and CMake with macOS, Linux and Windows)
Thanks,
Jan Schlicht