You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/08 09:41:21 UTC
[GitHub] [shardingsphere] DreamerBear opened a new pull request #5472: Fixes #5467
DreamerBear opened a new pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472
Fixes #5467
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamerBear commented on a change in pull request #5472: Fixes #5467
Posted by GitBox <gi...@apache.org>.
DreamerBear commented on a change in pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472#discussion_r422443163
##########
File path: shardingsphere-underlying/shardingsphere-executor/src/main/java/org/apache/shardingsphere/underlying/executor/sql/execute/jdbc/queryresult/MemoryQueryResult.java
##########
@@ -81,7 +81,8 @@ private Object getRowValue(final ResultSet resultSet, final int columnIndex) thr
if (metaData.isSigned(columnIndex)) {
return resultSet.getLong(columnIndex);
}
- return resultSet.getBigDecimal(columnIndex).toBigInteger();
+ Object result = resultSet.getBigDecimal(columnIndex);
Review comment:
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on pull request #5472: Fixes #5467
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472#issuecomment-626101692
5.0.0 will include this fix. See the milestone label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #5472: Fixes #5467
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472#discussion_r422074038
##########
File path: shardingsphere-underlying/shardingsphere-executor/src/main/java/org/apache/shardingsphere/underlying/executor/sql/execute/jdbc/queryresult/MemoryQueryResult.java
##########
@@ -81,7 +81,8 @@ private Object getRowValue(final ResultSet resultSet, final int columnIndex) thr
if (metaData.isSigned(columnIndex)) {
return resultSet.getLong(columnIndex);
}
- return resultSet.getBigDecimal(columnIndex).toBigInteger();
+ Object result = resultSet.getBigDecimal(columnIndex);
Review comment:
1. Object => BigDecimal
2. Generally we use 'result' to naming the return item in a function. Actually we don't return the 'result' here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5472: Fixes #5467
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472#issuecomment-626097406
## Pull Request Test Coverage Report for [Build 11516](https://coveralls.io/builds/30667975)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* **126** unchanged lines in **11** files lost coverage.
* Overall coverage decreased (**-0.08%**) to **58.169%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/boot/OrchestrationSpringBootConfiguration.java](https://coveralls.io/builds/30667975/source?filename=sharding-spring%2Fsharding-jdbc-orchestration-spring%2Fsharding-jdbc-orchestration-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fspring%2Fboot%2FOrchestrationSpringBootConfiguration.java#L165) | 2 | 94.87% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/30667975/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L50) | 3 | 0% |
| [shardingsphere-underlying/shardingsphere-executor/src/main/java/org/apache/shardingsphere/underlying/executor/kernel/ExecutorKernel.java](https://coveralls.io/builds/30667975/source?filename=shardingsphere-underlying%2Fshardingsphere-executor%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fexecutor%2Fkernel%2FExecutorKernel.java#L120) | 4 | 87.18% |
| [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-boot-starter/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/boot/SpringBootConfiguration.java](https://coveralls.io/builds/30667975/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-boot-starter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fboot%2FSpringBootConfiguration.java#L139) | 4 | 87.5% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemas.java](https://coveralls.io/builds/30667975/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemas.java#L77) | 6 | 33.33% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/30667975/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L55) | 7 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/schema/SchemaMetaDataLoader.java](https://coveralls.io/builds/30667975/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fschema%2FSchemaMetaDataLoader.java#L49) | 11 | 0% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/30667975/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L73) | 18 | 6.82% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/30667975/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L70) | 18 | 6.82% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/30667975/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L74) | 18 | 0% |
<!-- | **Total:** | **126** | | -->
| Totals | [](https://coveralls.io/builds/30667975) |
| :-- | --: |
| Change from base [Build 11489](https://coveralls.io/builds/30647447): | -0.08% |
| Covered Lines: | 12009 |
| Relevant Lines: | 20645 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #5472: Fixes #5467
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472#discussion_r422074505
##########
File path: shardingsphere-underlying/shardingsphere-executor/src/main/java/org/apache/shardingsphere/underlying/executor/sql/execute/jdbc/queryresult/MemoryQueryResult.java
##########
@@ -81,7 +81,8 @@ private Object getRowValue(final ResultSet resultSet, final int columnIndex) thr
if (metaData.isSigned(columnIndex)) {
return resultSet.getLong(columnIndex);
}
- return resultSet.getBigDecimal(columnIndex).toBigInteger();
+ Object result = resultSet.getBigDecimal(columnIndex);
Review comment:
Maybe result => bigDecimal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamerBear commented on pull request #5472: Fixes #5467
Posted by GitBox <gi...@apache.org>.
DreamerBear commented on pull request #5472:
URL: https://github.com/apache/shardingsphere/pull/5472#issuecomment-626099541
I would like to ask, which version will fix this problem? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org