You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by wilsonpinto360 <gi...@git.apache.org> on 2015/08/10 17:26:41 UTC
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
GitHub user wilsonpinto360 opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57
Android : add SplashShowOnlyFirstTime as preference
Defaults to true like before, but when changed to false this will make possible show again splashscreen after navigator.app.exitApp() is call and then event resume is trigger.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wilsonpinto360/cordova-plugin-splashscreen patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit e46443a1254b5fee04236dbe4c2fce29597c403a
Author: Wilson Pinto <wi...@gmail.com>
Date: 2015-08-10T15:26:24Z
Android : add SplashShowOnlyFirstTime as preference
Defaults to true like before, but when changed to false this will make possible show again splashscreen after navigator.app.exitApp() is call and then event resume is trigger.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by sgo13 <gi...@git.apache.org>.
Github user sgo13 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-142111499
Finally It's working I was making a mistake when deploying the modifications of SplashScreen.java.
Thank you for you help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-167245537
@wilsonpinto360, thanks for the fix,
Could you please rename this to `CB-9374 Android: add SplashShowOnlyFirstTime as preference`?
Also I could not find you in the [Cordova contributors list](http://people.apache.org/committer-index.html) - could you please sign an ICLA?
http://www.apache.org/dev/new-committers-guide.html#cla
Related issues: [CB-9374](https://issues.apache.org/jira/browse/CB-9374), [CB-10261](https://issues.apache.org/jira/browse/CB-10261)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-167353529
@daserge i did restore fork on pr #70.
Everything should be ready now. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-169778334
Docs need to be updated talking about this preference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by arenddeboer <gi...@git.apache.org>.
Github user arenddeboer commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-152726691
Thank you for this pull request, I was pulling my hair why the splashscreen was only showing once when people "close" the app by using the back button.
Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-153372688
@arenddeboer :+1: same happened to me before :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-169778462
@daserge Can you help merge this after making the docs update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-169828497
@nikhilkh it already was merged, check #70.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-167259061
@wilsonpinto360, thanks, and Merry Christmas!
Looks like you have deleted your fork - can you please restore it?
It also makes sense to mention this new option in [the plugin docs](https://github.com/apache/cordova-plugin-splashscreen/blob/master/README.md#android-quirks).
The commit title should also be renamed to `CB-9374 Android: add SplashShowOnlyFirstTime as preference`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by sgo13 <gi...@git.apache.org>.
Github user sgo13 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-142013221
I'd like to show splashscreen again after navigator.app.exitApp() but I can't get it work even with that modification.
Is there something else to do ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9374 Android: add Spl...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-167251986
@daserge,
i just submitted signed ICLA, so it should be there in next days.
Thank you and Merry Xmas :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-142112483
No problem, you are welcome :)
2015-09-21 22:21 GMT+01:00 sgo13 <no...@github.com>:
> Finally It's working I was making a mistake when deploying the
> modifications of SplashScreen.java.
> Thank you for you help.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-142111499>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by sgo13 <gi...@git.apache.org>.
Github user sgo13 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-142099362
Yes, I have added <preference name="SplashShowOnlyFirstTime" value="false" /> in my config.xml...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by nglrt <gi...@git.apache.org>.
Github user nglrt commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-160208917
We'd be happy if this change gets merged... :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Android : add SplashShow...
Posted by wilsonpinto360 <gi...@git.apache.org>.
Github user wilsonpinto360 commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/57#issuecomment-142035634
@sgo13 did you add also <preference name="SplashShowOnlyFirstTime" value="false" /> property to config.xml? it works perfectly for me on several apps
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org