You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/01/25 06:44:47 UTC

[GitHub] knight9999 opened a new pull request #504: GH-407: supports autormatic provisioning in Xcode 10

knight9999 opened a new pull request #504: GH-407: supports autormatic provisioning in Xcode 10
URL: https://github.com/apache/cordova-ios/pull/504
 
 
   
   ### Platforms affected
   cordova-ios
   
   ### What does this PR do?
   To fix the issue #407 wjere the automatic provisioning is specified. This PR is according to the comment https://github.com/apache/cordova-ios/issues/407#issuecomment-455107551 .
   
   ### What testing has been done on this change?
   
   In xcode 10, exporting archives from xcarchive with automatic provisioning has an issue. As a result, ios-deploy debugging does not work correctly. (after launching, it stops soon).
   Therefore this PR finds an appropriate provisioning file registered in local mac and uses that file to export an archive (.ipa file) in cordova/lib/build.js.
   
   How to find appropriate provisioing file logic is followings.
   1. get all provisioing files under 'Library/MobileDevice/Provisioning Profiles'.
   2. get all valid certificates by using the command `security find-identity -v -p codesigning`.
   3. select provisioning files associated with one of valid certificates.
   4  sort provisioning files by app id (bundle id) length desc 
   (e.g.
   xxx.yyy.zzz takes priority over xxx.yyy.*. 
   xxx.yyy.* takes priority over *.
   )
   5  sort provisioing files by created date desc.
   (newly create provisioing takes priority)
   5. drop provisioning files where IsXcodeManaged = true 
   6. drop provisioning files where invalid build type. (development for develop,  release for release)
   7. drop invalid team ID
   8. If there is a USB connected iPhone/iPad, drop provisioning files which does not support the USB connected iPhone/iPad's device ID. (If two or more iPhone/iPad are connected, only first one is checked) 
   9. drop provisioning files whose bundle id does not match the one in the project.
   10. choose a first provisioning file of resulting provisiong files.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org