You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "HattoriHenzo (via GitHub)" <gi...@apache.org> on 2023/03/14 00:21:29 UTC
[GitHub] [incubator-eventmesh] HattoriHenzo opened a new pull request, #3447: [ISSUE #3445] Refactor SubscribeTask
HattoriHenzo opened a new pull request, #3447:
URL: https://github.com/apache/incubator-eventmesh/pull/3447
Fixes https://github.com/apache/incubator-eventmesh/issues/3445
### Motivation
Refactor `SubscribeTask` by isolating the logic into another class `Subscribe`
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #3447: [ISSUE #3445] Refactor SubscribeTask
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3447:
URL: https://github.com/apache/incubator-eventmesh/pull/3447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on pull request #3447: [ISSUE #3445] Refactor SubscribeTask
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3447:
URL: https://github.com/apache/incubator-eventmesh/pull/3447#issuecomment-1467420623
Please check checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3447: [ISSUE #3445] Refactor SubscribeTask
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3447:
URL: https://github.com/apache/incubator-eventmesh/pull/3447#issuecomment-1468882499
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3447](https://codecov.io/gh/apache/incubator-eventmesh/pull/3447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (accd7b6) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/3a1a5adfa4e3f728c39c2a152e53dae0f0e1f682?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a1a5ad) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head accd7b6 differs from pull request most recent head 1741bc0. Consider uploading reports for the commit 1741bc0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3447 +/- ##
============================================
- Coverage 13.92% 13.91% -0.01%
Complexity 1438 1438
============================================
Files 636 637 +1
Lines 31375 31387 +12
Branches 3008 3008
============================================
Hits 4368 4368
- Misses 26630 26642 +12
Partials 377 377
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mesh/storage/standalone/broker/task/Subscribe.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utc3RhbmRhbG9uZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3N0b3JhZ2Uvc3RhbmRhbG9uZS9icm9rZXIvdGFzay9TdWJzY3JpYmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../storage/standalone/broker/task/SubscribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utc3RhbmRhbG9uZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3N0b3JhZ2Uvc3RhbmRhbG9uZS9icm9rZXIvdGFzay9TdWJzY3JpYmVUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...torage/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utc3RhbmRhbG9uZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3N0b3JhZ2Uvc3RhbmRhbG9uZS9jb25zdW1lci9TdGFuZGFsb25lQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org