You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Tao Yang (Jira)" <ji...@apache.org> on 2020/04/08 08:44:00 UTC
[jira] [Commented] (YUNIKORN-82) Wrong revision in docker image
[ https://issues.apache.org/jira/browse/YUNIKORN-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077942#comment-17077942 ]
Tao Yang commented on YUNIKORN-82:
----------------------------------
Thanks [~wwei] for reporting this issue.
I have ignored the commands and only update the project name from "yunikorn-xxx" to "incubator-yunikorn-xxx", the target split in get-revision commands for yunikorn-core-revision and yunikorn-scheduler-interface-revision should be updated at the same time.
Already created PR for this issue, please help to review it. Thanks.
> Wrong revision in docker image
> ------------------------------
>
> Key: YUNIKORN-82
> URL: https://issues.apache.org/jira/browse/YUNIKORN-82
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
> Reporter: Weiwei Yang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Reproduce steps
> # from k8shim, build the scheduler docker image, such as: yunikorn/yunikorn-scheduler-k8s:latest
> # then run "docker inspect yunikorn/yunikorn-scheduler-k8s:latest"
> # check Labels
> "Labels": \{ "BuildTimeStamp": "2020-04-07T10:17:10-0700", "Version": "latest", "yunikorn-core-revision": "20200403014952", "yunikorn-k8shim-revision": "0c83fd7f5ff5", "yunikorn-scheduler-interface-revision": "20200327234544" }
> Looks like the revision for {{yunikorn-core-revision}} and {{yunikorn-scheduler-interface-revision}} are incorrect. Code to set this is in Makefile
> {code:java}
> ...
> @coreSHA=$$(go list -m "github.com/apache/incubator-yunikorn-core" | cut -d "-" -f4) ; \
> siSHA=$$(go list -m "github.com/apache/incubator-yunikorn-scheduler-interface" | cut -d "-" -f5) ; \
> shimSHA=$$(git rev-parse --short=12 HEAD) ; \
> docker build ./deployments/image/configmap -t ${REGISTRY}/yunikorn-scheduler-k8s:${VERSION} \
> --label "yunikorn-core-revision=$${coreSHA}" \
> --label "yunikorn-scheduler-interface-revision=$${siSHA}" \
> --label "yunikorn-k8shim-revision=$${shimSHA}" \
> --label "BuildTimeStamp=${DATE}" \
> --label "Version=${VERSION}"
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org