You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Arin Tripathi (Jira)" <ji...@apache.org> on 2023/06/29 13:34:00 UTC

[jira] [Comment Edited] (CAMEL-19547) camel-xmpp: replace Thread.sleep in tests

    [ https://issues.apache.org/jira/browse/CAMEL-19547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738577#comment-17738577 ] 

Arin Tripathi edited comment on CAMEL-19547 at 6/29/23 1:33 PM:
----------------------------------------------------------------

So
{noformat}
xmppServer.startXmppEndpoint();
Thread.Sleep(2000){noformat}
 

will become

 
{noformat}
Awaitility
        .await()
        .atMost(Durations.TWO_SECONDS);{noformat}


was (Author: itachi):
So
{noformat}
Thread.Sleep(2000){noformat}
 

will become

 
{noformat}
Awaitility
        .await()
        .atMost(Durations.TWO_SECONDS);{noformat}

> camel-xmpp: replace Thread.sleep in tests
> -----------------------------------------
>
>                 Key: CAMEL-19547
>                 URL: https://issues.apache.org/jira/browse/CAMEL-19547
>             Project: Camel
>          Issue Type: Task
>          Components: camel-xmpp, tests
>    Affects Versions: 4.0.0
>            Reporter: Otavio Rodolfo Piske
>            Priority: Minor
>              Labels: easy, help-wanted
>
> We have many tests which use Thread.sleep for synchronization. This is bug prone and can introduce flakiness when running on environments with different capacities.
> Ideally we should replace these with:
>  * [Awaitility|http://www.awaitility.org/]
>  * Java's native syncronization mechanism (Latches, Phasers, Locks, etc)
>  * Nothing (i.e.; in some cases the sleep can simply be removed)
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)