[GitHub] [netbeans] matthiasblaesing commented on pull request #2874: [NETBEANS-5427] Replace usage of JDK internal xerces Base64 encoder in TomcatDeployer

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #2874:
URL: https://github.com/apache/netbeans/pull/2874#issuecomment-817331679


   Indeed it would be good to remove the referenced implementation or at least make them shims to call into the JDK implementation (if they are API). I had a quick look at all three implementations though and all of them are full implementations and don't call into restricted JDK apis.
   
   @piercemar would you be willing to have a look?
   
   Two other things:
   
   - The author information is invalid - the email address is not valid (looks like an edit on github, if you work on github please ensure, that your full name is publically visible _and_ and valid public emailaddress is set).
   - it is assumed, that you had a look at the license statement of the files you changed and agree, that your changes are donated to the ASF.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists