You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by za...@apache.org on 2015/03/05 09:14:12 UTC

[1/2] cordova-plugin-geolocation git commit: Wrong parameter in Firefox OS plugin

Repository: cordova-plugin-geolocation
Updated Branches:
  refs/heads/master 828471f9c -> 399b164b6


Wrong parameter in Firefox OS plugin

Calling geolocation.watchPosition() in Firefox OS will return empty coords because addWatch() omits same position object conversion like in getLocation().

Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/commit/3b06100d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/tree/3b06100d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/diff/3b06100d

Branch: refs/heads/master
Commit: 3b06100d419f550208a71581bf3a9ae44f461a75
Parents: 7dc4400
Author: Jojo Degenhardt <jo...@gmail.com>
Authored: Fri Nov 21 08:24:23 2014 +0100
Committer: Jojo Degenhardt <jo...@gmail.com>
Committed: Fri Nov 21 08:24:23 2014 +0100

----------------------------------------------------------------------
 src/firefoxos/GeolocationProxy.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/blob/3b06100d/src/firefoxos/GeolocationProxy.js
----------------------------------------------------------------------
diff --git a/src/firefoxos/GeolocationProxy.js b/src/firefoxos/GeolocationProxy.js
index 5a6ae7d..e4b4052 100644
--- a/src/firefoxos/GeolocationProxy.js
+++ b/src/firefoxos/GeolocationProxy.js
@@ -39,7 +39,10 @@ module.exports = {
     addWatch: function(success, error, args) {
         var geo = cordova.require('cordova/modulemapper').getOriginalSymbol(window, 'navigator.geolocation');        
         var id = args[0];
-        var nativeId = geo.watchPosition(success, error, {
+        function successCallback(position) {
+          success(position.coords);
+        }
+        var nativeId = geo.watchPosition(successCallback, error, {
             enableHighAccuracy: args[1]
         });
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[2/2] cordova-plugin-geolocation git commit: Merge branch 'master' of github.com:DrJojo/cordova-plugin-geolocation

Posted by za...@apache.org.
Merge branch 'master' of github.com:DrJojo/cordova-plugin-geolocation


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/commit/399b164b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/tree/399b164b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation/diff/399b164b

Branch: refs/heads/master
Commit: 399b164b66595e734883ea5001b932f573d5003e
Parents: 828471f 3b06100
Author: Piotr Zalewa <pi...@zalewa.info>
Authored: Thu Mar 5 09:13:55 2015 +0100
Committer: Piotr Zalewa <pi...@zalewa.info>
Committed: Thu Mar 5 09:13:55 2015 +0100

----------------------------------------------------------------------
 src/firefoxos/GeolocationProxy.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org