You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/07/06 17:26:01 UTC
[Impala-ASF-CR] IMPALA-7201. Support DDL with LocalCatalog enabled
Hello Tianyi Wang, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10806
to look at the new patch set (#2).
Change subject: IMPALA-7201. Support DDL with LocalCatalog enabled
......................................................................
IMPALA-7201. Support DDL with LocalCatalog enabled
This fixes a couple issues with DDL commands when LocalCatalog is
enabled:
- updateCatalogCache() gets called after any DDL. Instead of throwing an
exception, we can just no-op this by returning some fake result.
- In order to support 'drop database' we need to properly implement the
various function-related calls such that they don't throw exceptions.
This changes them to be stubbed out as having no functions.
- Fixes for 'alter view' and 'drop view' so that the underlying target
table gets loaded by the catalogd before attempting the operation.
Without this, in the LocalCatalog case, the catalogd would only have
an IncompleteTable and these operations would fail with "unexpected
table type" errors.
With this patch I was able to run 'run-tests.py -k views' and 3/4
passed. The one that failed depends on HBase tables, not yet
implemented.
Change-Id: Ic39c97a5f5ad145e03b96d1a470dc2dfa6ec71a5
---
M fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/FeCatalogManager.java
3 files changed, 33 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/10806/2
--
To view, visit http://gerrit.cloudera.org:8080/10806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic39c97a5f5ad145e03b96d1a470dc2dfa6ec71a5
Gerrit-Change-Number: 10806
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>