You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by om...@apache.org on 2015/10/30 13:05:41 UTC

android commit: CB-9909 Shouldn't escape spaces in paths on Windows.. This closes #237

Repository: cordova-android
Updated Branches:
  refs/heads/master 671219ae5 -> 1c90a7732


CB-9909 Shouldn't escape spaces in paths on Windows.. This closes #237


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/1c90a773
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/1c90a773
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/1c90a773

Branch: refs/heads/master
Commit: 1c90a7732526d7d71be88d121b61c8e6dcf3769b
Parents: 671219a
Author: Tim Barham <ti...@microsoft.com>
Authored: Thu Oct 29 15:30:48 2015 -0700
Committer: Omar Mefire <om...@gmail.com>
Committed: Fri Oct 30 04:58:26 2015 -0700

----------------------------------------------------------------------
 bin/lib/check_reqs.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/1c90a773/bin/lib/check_reqs.js
----------------------------------------------------------------------
diff --git a/bin/lib/check_reqs.js b/bin/lib/check_reqs.js
index d3a93e1..73b2b99 100644
--- a/bin/lib/check_reqs.js
+++ b/bin/lib/check_reqs.js
@@ -230,8 +230,12 @@ module.exports.check_android = function() {
     });
 };
 
-module.exports.getAbsoluteAndroidCmd = function() {
-    return forgivingWhichSync('android').replace(/(\s)/g, '\\$1');
+module.exports.getAbsoluteAndroidCmd = function () {
+    var cmd = forgivingWhichSync('android');
+    if (process.platform === 'win32') {
+        return '"' + cmd + '"';
+    }
+    return cmd.replace(/(\s)/g, '\\$1');
 };
 
 module.exports.check_android_target = function(valid_target) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org