You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/03/27 14:22:07 UTC
[GitHub] [myfaces] astappiev opened a new pull request #90: Incorrect
Last-Modified header for resources
astappiev opened a new pull request #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90
We conduct an issue that our resources have incorrect header: `Last-Modified: Thu, 01 Jan 1970 00:00:00 GMT`.
After investigating the issue, I found that we deploy using Tomcat with a version tag and a path to resources contains special characters (`#`).
And this method can not read the resources, because the URL (file path) contains URL Encoded characters (for OS this is not a valid path) like this: `/some-path/tomcat/webapps/v3%23%233.2.1/resources/layout/js/layout.js`.
I'm not sure if this PR is the best solution. But it solves this issue for us.
Now I created a custom implementation of ResourceHalder and Resource (just a copy of myfaces impls) to update the method and fix this issue. It would be good if you can release a fix, or give a hint on how to patch it easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #90: Incorrect
Last-Modified header for resources
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90#issuecomment-609071048
@astappiev Thanks!
Could you please try to remove the "file".equals-statement and always call
`getResourceLastModified(url.openConnection());` ?
Does this work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #90: Incorrect Last-Modified
header for resources
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90#issuecomment-609032506
https://issues.apache.org/jira/browse/MYFACES-4326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #90: Incorrect
Last-Modified header for resources
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90#issuecomment-609408162
ok
could you please modify the PR?
And it would be great if you can also add the changes to 3.0.x branch and master branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #90: Incorrect
Last-Modified header for resources
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90#issuecomment-605138088
Could you please create a JIRA issue first? (thats how someone should start before creating a PR :D, thanks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko merged pull request #90: Incorrect
Last-Modified header for resources
Posted by GitBox <gi...@apache.org>.
tandraschko merged pull request #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #90: Incorrect
Last-Modified header for resources
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90#issuecomment-612477840
looks good, thanks!
can you also provide it for the other branches i mentioned? so i can merge it and close the issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] astappiev commented on issue #90: Incorrect Last-Modified
header for resources
Posted by GitBox <gi...@apache.org>.
astappiev commented on issue #90: Incorrect Last-Modified header for resources
URL: https://github.com/apache/myfaces/pull/90#issuecomment-609088452
Yes, all values as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services