You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:46:59 UTC
[GitHub] [spark] MaxGekk commented on a change in pull request #28001:
[SPARK-31237][SQL][TESTS] Replace 3-letter time zones by zone offsets
MaxGekk commented on a change in pull request #28001: [SPARK-31237][SQL][TESTS] Replace 3-letter time zones by zone offsets
URL: https://github.com/apache/spark/pull/28001#discussion_r398090030
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchemaSuite.scala
##########
@@ -22,13 +22,15 @@ import java.util.Locale
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.catalyst.plans.SQLHelper
+import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.UTC
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
class CSVInferSchemaSuite extends SparkFunSuite with SQLHelper {
test("String fields types are inferred correctly from null types") {
- val options = new CSVOptions(Map("timestampFormat" -> "yyyy-MM-dd HH:mm:ss"), false, "GMT")
Review comment:
I replaced `GMT` by `UTC`, and `UTC.getId` by `UTC`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org