You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/06/25 23:49:20 UTC
Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for transferred
data
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12092/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1073
https://issues.apache.org/jira/browse/SQOOP-1073
Repository: sqoop-sqoop2
Description
-------
Full implementation of the first schema drop. It is adding all facilities required to describe, create and transfer the schema. Further tweaking will be required and will be done in follow up JIRAs.
Diffs
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162e76122451bf0e52f8749af610a37837e8
client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 360a9318f268ba7b266307df2f9f1de2d6fd4ade
client/src/main/resources/client-resource.properties 8a570a1621ce37225d2e72b70aa332564a3ffa0a
common/pom.xml 2921800aa1cde5f8df476ca14ca3218de11884c5
common/src/main/java/org/apache/sqoop/json/SchemaBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 91f2007f00b5c0e6cefa8a7feb03257b3b13866c
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MSubmission.java e15c46651aad7bfe3969d051390756a14dd338b3
common/src/main/java/org/apache/sqoop/schema/Schema.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/SchemaError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Array.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Binary.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Bit.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Column.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Date.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Enum.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Map.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Set.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Text.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Time.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Type.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 19a5bbad7ef4714deb118f69c14e24cf36ccf390
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java f2ac979d1fe128de385025534b7979789685ed2a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 40a777499492a3b18f1fee1fd96222c77b8868ce
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 3e9789c35e1e56d53d30257801cc8ce6194bbc0c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 9f4269a0ef7579b72a437e167a15a91408e5537d
core/src/main/java/org/apache/sqoop/framework/JobManager.java 5a2f490c6702edd359e7867d30df76bd745a1824
spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 346b84c34d5ed71faf74650d842c7581f5e880e5
Diff: https://reviews.apache.org/r/12092/diff/
Testing
-------
Both unit and integration tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for
transferred data
Posted by Mengwei Ding <me...@cloudera.com>.
> On July 1, 2013, 4:36 p.m., Mengwei Ding wrote:
> > common/src/main/java/org/apache/sqoop/schema/Schema.java, line 20
> > <https://reviews.apache.org/r/12092/diff/2/?file=313292#file313292line20>
> >
> > Hi, Jarce, I find a tiny error here. I think the StringUtils in the org.apache.commons.utils package rather than the lang package.
well. it seems like the dependency in my eclipse got some errors. Please forget it.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12092/#review22610
-----------------------------------------------------------
On June 29, 2013, 9:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12092/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1073
> https://issues.apache.org/jira/browse/SQOOP-1073
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Full implementation of the first schema drop. It is adding all facilities required to describe, create and transfer the schema. Further tweaking will be required and will be done in follow up JIRAs.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162e76122451bf0e52f8749af610a37837e8
> client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 360a9318f268ba7b266307df2f9f1de2d6fd4ade
> client/src/main/resources/client-resource.properties 8a570a1621ce37225d2e72b70aa332564a3ffa0a
> common/pom.xml 2921800aa1cde5f8df476ca14ca3218de11884c5
> common/src/main/java/org/apache/sqoop/json/SchemaBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 91f2007f00b5c0e6cefa8a7feb03257b3b13866c
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MSubmission.java e15c46651aad7bfe3969d051390756a14dd338b3
> common/src/main/java/org/apache/sqoop/schema/Schema.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/SchemaError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Array.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Column.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Date.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Map.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Set.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Text.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Time.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Type.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 19a5bbad7ef4714deb118f69c14e24cf36ccf390
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java f2ac979d1fe128de385025534b7979789685ed2a
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 40a777499492a3b18f1fee1fd96222c77b8868ce
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 3e9789c35e1e56d53d30257801cc8ce6194bbc0c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 9f4269a0ef7579b72a437e167a15a91408e5537d
> core/src/main/java/org/apache/sqoop/framework/JobManager.java 5a2f490c6702edd359e7867d30df76bd745a1824
> spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 346b84c34d5ed71faf74650d842c7581f5e880e5
>
> Diff: https://reviews.apache.org/r/12092/diff/
>
>
> Testing
> -------
>
> Both unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for
transferred data
Posted by Mengwei Ding <me...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12092/#review22610
-----------------------------------------------------------
common/src/main/java/org/apache/sqoop/schema/Schema.java
<https://reviews.apache.org/r/12092/#comment46307>
Hi, Jarce, I find a tiny error here. I think the StringUtils in the org.apache.commons.utils package rather than the lang package.
- Mengwei Ding
On June 29, 2013, 9:11 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12092/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 9:11 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1073
> https://issues.apache.org/jira/browse/SQOOP-1073
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Full implementation of the first schema drop. It is adding all facilities required to describe, create and transfer the schema. Further tweaking will be required and will be done in follow up JIRAs.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162e76122451bf0e52f8749af610a37837e8
> client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 360a9318f268ba7b266307df2f9f1de2d6fd4ade
> client/src/main/resources/client-resource.properties 8a570a1621ce37225d2e72b70aa332564a3ffa0a
> common/pom.xml 2921800aa1cde5f8df476ca14ca3218de11884c5
> common/src/main/java/org/apache/sqoop/json/SchemaBean.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 91f2007f00b5c0e6cefa8a7feb03257b3b13866c
> common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/model/MSubmission.java e15c46651aad7bfe3969d051390756a14dd338b3
> common/src/main/java/org/apache/sqoop/schema/Schema.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/SchemaError.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Array.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Binary.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Bit.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Column.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Date.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/DateTime.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Decimal.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Enum.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Map.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Set.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Text.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Time.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Type.java PRE-CREATION
> common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 19a5bbad7ef4714deb118f69c14e24cf36ccf390
> common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java f2ac979d1fe128de385025534b7979789685ed2a
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 40a777499492a3b18f1fee1fd96222c77b8868ce
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 3e9789c35e1e56d53d30257801cc8ce6194bbc0c
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java PRE-CREATION
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 9f4269a0ef7579b72a437e167a15a91408e5537d
> core/src/main/java/org/apache/sqoop/framework/JobManager.java 5a2f490c6702edd359e7867d30df76bd745a1824
> spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 346b84c34d5ed71faf74650d842c7581f5e880e5
>
> Diff: https://reviews.apache.org/r/12092/diff/
>
>
> Testing
> -------
>
> Both unit and integration tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for
transferred data
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12092/
-----------------------------------------------------------
(Updated June 29, 2013, 9:11 p.m.)
Review request for Sqoop.
Changes
-------
Initializing hashCode() computation to nonzero value.
Bugs: SQOOP-1073
https://issues.apache.org/jira/browse/SQOOP-1073
Repository: sqoop-sqoop2
Description
-------
Full implementation of the first schema drop. It is adding all facilities required to describe, create and transfer the schema. Further tweaking will be required and will be done in follow up JIRAs.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 06f8162e76122451bf0e52f8749af610a37837e8
client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 360a9318f268ba7b266307df2f9f1de2d6fd4ade
client/src/main/resources/client-resource.properties 8a570a1621ce37225d2e72b70aa332564a3ffa0a
common/pom.xml 2921800aa1cde5f8df476ca14ca3218de11884c5
common/src/main/java/org/apache/sqoop/json/SchemaBean.java PRE-CREATION
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 91f2007f00b5c0e6cefa8a7feb03257b3b13866c
common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MSubmission.java e15c46651aad7bfe3969d051390756a14dd338b3
common/src/main/java/org/apache/sqoop/schema/Schema.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/SchemaError.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractComplexType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractDateTime.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractNumber.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/AbstractString.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Array.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Binary.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Bit.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Column.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Date.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/DateTime.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Decimal.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Enum.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/FixedPoint.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/FloatingPoint.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Map.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Set.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Text.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Time.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Type.java PRE-CREATION
common/src/main/java/org/apache/sqoop/schema/type/Unsupported.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 19a5bbad7ef4714deb118f69c14e24cf36ccf390
common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java f2ac979d1fe128de385025534b7979789685ed2a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 40a777499492a3b18f1fee1fd96222c77b8868ce
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 3e9789c35e1e56d53d30257801cc8ce6194bbc0c
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/util/SqlTypesUtils.java PRE-CREATION
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 9f4269a0ef7579b72a437e167a15a91408e5537d
core/src/main/java/org/apache/sqoop/framework/JobManager.java 5a2f490c6702edd359e7867d30df76bd745a1824
spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 346b84c34d5ed71faf74650d842c7581f5e880e5
Diff: https://reviews.apache.org/r/12092/diff/
Testing
-------
Both unit and integration tests seems to be passing.
Thanks,
Jarek Cecho