[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1909: chore: sync JSON Schema from APISIX 2.6

[GitBox <gi...@apache.org>]

imjoey commented on a change in pull request #1909:
URL: https://github.com/apache/apisix-dashboard/pull/1909#discussion_r636780965



##########
File path: api/internal/core/entity/entity.go
##########
@@ -157,21 +157,22 @@ type HealthChecker struct {
 }
 
 type UpstreamDef struct {
-	Nodes         interface{}       `json:"nodes,omitempty"`
-	Retries       int               `json:"retries,omitempty"`
-	Timeout       interface{}       `json:"timeout,omitempty"`
-	Type          string            `json:"type,omitempty"`
-	Checks        interface{}       `json:"checks,omitempty"`
-	HashOn        string            `json:"hash_on,omitempty"`
-	Key           string            `json:"key,omitempty"`
-	Scheme        string            `json:"scheme,omitempty"`
-	DiscoveryType string            `json:"discovery_type,omitempty"`
-	PassHost      string            `json:"pass_host,omitempty"`
-	UpstreamHost  string            `json:"upstream_host,omitempty"`
-	Name          string            `json:"name,omitempty"`
-	Desc          string            `json:"desc,omitempty"`
-	ServiceName   string            `json:"service_name,omitempty"`
-	Labels        map[string]string `json:"labels,omitempty"`
+	Nodes         interface{}            `json:"nodes,omitempty"`
+	Retries       *int                   `json:"retries,omitempty"`

Review comment:
       Hi, any reason to change `int` to `*int` here? Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org