[GitHub] [ozone] umamaheswararao commented on a change in pull request #2069: HDDS-4883. Persist replicationIndex on datanode side

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r631330772



##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws IOException{
       GenericTestUtils.assertExceptionContains("No enum constant", ex);
     }
   }
-
-

Review comment:
       I meant that, after EC branch merged, but not using EC containers at all, will have not  any impact at all if we skip writing index. 
   Anyway for the EC containers, we need to deal. One question: do we allow old code DN to serve the EC container data?
   I am worried that Old DN will not know if there is any EC specific logic added at DN.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org