[GitHub] [flink] luoyuxia commented on a diff in pull request #19193: [FLINK-26813[SQL-API] Supports ADD/MODIFY column/watermark/constraint syntax parse for ALTER TABLE

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #19193:
URL: https://github.com/apache/flink/pull/19193#discussion_r843440633


##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterTable.java:
##########
@@ -94,4 +97,15 @@ public SqlNodeList getPartitionSpec() {
     public LinkedHashMap<String, String> getPartitionKVs() {
         return SqlPartitionUtils.getPartitionKVs(getPartitionSpec());
     }
+
+    protected void printIndent(SqlWriter writer) {
+        writer.sep(",", false);
+        writer.newlineAndIndent();
+        writer.print("  ");
+    }
+
+    /** Alter table context. */
+    public static class AlterTableContext extends SqlCreateTable.TableCreationContext {
+        public List<SqlNode> columnPositions = new ArrayList<>();

Review Comment:
   Do we need `columnPositions`? Seems it is never used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org