You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2002/06/05 05:53:29 UTC

DO NOT REPLY [Bug 9617] New: - [PATCH] Fix contrib/artimus JSPs so that they are well formed HTML/JSP

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9617>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9617

[PATCH] Fix contrib/artimus JSPs so that they are well formed HTML/JSP

           Summary: [PATCH] Fix contrib/artimus JSPs so that they are well
                    formed HTML/JSP
           Product: Struts
           Version: Nightly Build
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Example
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: kinonn@scioworks.com


Some of the JSPs in the Artimus examples are not well formed and show up as
errors in HTML/JSP validators and parsers. Below are the patches which fix the
various files.

---

File: /contrib/artimus/pages/article/Form.jsp

C:\Dev\jakarta-struts-020603\contrib\artimus\pages\article>diff -u Form.jsp.orig
Form.jsp
--- Form.jsp.orig       Mon Jun 03 02:28:02 2002
+++ Form.jsp    Tue Jun 04 22:28:39 2002
@@ -74,7 +74,9 @@
                 </td>
                 <td align="left">
                 </td>
-              </tr>                <td align="right" nowrap>Article ID:</td>
+              </tr>
+              <tr>
+                <td align="right" nowrap>Article ID:</td>
                 <logic:notPresent name="articleForm" property="article">
                   <td align="left"><i>
                     <html:hidden property="article"/>


//-------------------------------------------------------------------------------------

File: /contrib/artimus/pages/article/Menu.jsp

C:\Dev\jakarta-struts-020603\contrib\artimus\pages\article>diff -u Menu.jsp.orig
Menu.jsp

--- Menu.jsp.orig	Mon Jun 03 02:28:02 2002
+++ Menu.jsp	Tue Jun 04 22:42:16 2002
@@ -124,11 +124,11 @@
                         &nbsp;
                         <html:link forward="createTables">
                           CREATE TABLES
-                        </html:link></br>
+                        </html:link><br>
                         &nbsp;
                         <html:link forward="createIndex">
                           CREATE INDEX
-                        </html:link></br>
+                        </html:link><br>
                         &nbsp;
                         <html:link forward="reload">
                           RELOAD CONFIG
@@ -140,16 +140,15 @@
                 <td>&nbsp;</td>
               </tr>
             </req:isUserInRole>
-         </table>
+          </table>
         </td>
-        </tr>
-        <tr>
-          <td class="options">
-             <html:link forward="logon">LOGON</html:link> | 
-            <html:link forward="exit">EXIT</html:link>
-          </td>
-        </tr>
-      </table>
+      </tr>
+      <tr>
+        <td class="options">
+          <html:link forward="logon">LOGON</html:link> | 
+          <html:link forward="exit">EXIT</html:link>
+        </td>
+      </tr>
     </table>
   </body>
 </html:html>


//-------------------------------------------------------------------------------------

File: /contrib/artimus/pages/wizard/Form.jsp

C:\Dev\jakarta-struts-020603\contrib\artimus\pages\wizard>diff -u Form.jsp.orig
Form.jsp

--- Form.jsp.orig	Mon Jun 03 02:28:02 2002
+++ Form.jsp	Tue Jun 04 22:50:53 2002
@@ -9,7 +9,7 @@
 <%@ page language="java" %>
 <%@ taglib uri="/tags/struts-html" prefix="html" %>
 <%@ taglib uri="/tags/struts-bean" prefix="bean" %>
-<html:html/>
+<html:html>
 <head>
 <title>Form - String</title>
 <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
@@ -89,5 +89,5 @@
 </script>
 </table></td></tr>
 <tr><td align="center" bgcolor="#EEEEEE"></td></tr>
-</table></table></body></html>
+</table></body></html:html>


//-------------------------------------------------------------------------------------

File: /contrib/artimus/pages/wizard/Relay.jsp

C:\Dev\jakarta-struts-020603\contrib\artimus\pages\wizard>diff -u Relay.jsp.orig
Relay.jsp

--- Relay.jsp.orig	Mon Jun 03 02:28:02 2002
+++ Relay.jsp	Tue Jun 04 22:55:02 2002
@@ -93,4 +93,4 @@
 </script>
 </table></td></tr>
 <tr><td align="center" bgcolor="#EEEEEE"></td></tr>
-</table></table></body></html:html>
+</table></body></html:html>


//-------------------------------------------------------------------------------------

File: /contrib/artimus/pages/wizard/View.jsp

C:\Dev\jakarta-struts-020603\contrib\artimus\pages\wizard>diff -u View.jsp.orig
View.jsp

--- View.jsp.orig	Mon Jun 03 02:28:02 2002
+++ View.jsp	Tue Jun 04 22:58:30 2002
@@ -9,7 +9,7 @@
 <%@ page language="java" %>
 <%@ taglib uri="/tags/struts-html" prefix="html" %>
 <%@ taglib uri="/tags/struts-bean" prefix="bean" %>
-<html:html/>
+<html:html>
 <head>
 <title>View - String</title>
 <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
@@ -69,4 +69,4 @@
 
 </table></td></tr>
 <tr><td align="center" bgcolor="#EEEEEE"></td></tr>
-</table></table></body></html>
+</table></body></html:html>

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>