You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/24 15:16:51 UTC

[GitHub] [incubator-nuttx-apps] saramonteiro commented on pull request #628: examples/oneshot: fixed wrong constant and refactored

saramonteiro commented on pull request #628:
URL: https://github.com/apache/incubator-nuttx-apps/pull/628#issuecomment-805912501


   > LGTM All except but the name of NSEC_PER_USEC seams backwards, doesn't it?
   > 
   > Number for Seconds per micros Second should be NUSEC_PER_SEC, Number for micros Seconds per Second but that looks like anther PR....
   
   Hey David, 
   these definitions are not mine. They're from `include/nuttx/clock.h` and I don't think it's a good idea to change it.
   It will break several files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org