Re: One supported protocol per wagon

[Michal Maczka <mm...@interia.pl>]

Jason van Zyl wrote:

>Hi,
>
>There is another simplification I would like to make to the Wagon
>interface which concerns the number of supported protocols. I think we
>should limit the concern of the Wagon and have a single wagon deal with
>a single protocol.
>
>In the case of protocols like http and https the https component would
>subclass the http component and augment/override the openConnection
>method first but most of the logic would be used from the http wagon.
>
>I think this meshes well with the notion of one concern per component
>and generally makes Wagon easier to work with, it's an easy rule, and
>simplifies the component manager in general.
>
>I was about to try and get https to work and I think it would be better
>to implement the functionality in a separate component. I can't think of
>a case where there would be any download limiting a wagon to one
>supported protocol.
>
>If no one objects I will make this change to the interface and update
>the tests and all the Wagons.
>
>
>  
>
+1

Michal


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org