Re: Making Antora actionable

[David Jencks <da...@gmail.com>]

Sorry for the delay…. I love it!

I merged your PR to master and also rebased the home-page branch on it, I hope this doesn’t cause a lot of problems.

The preview is here, including my home-page work:  https://tomee-preview.s3-us-west-2.amazonaws.com/common/home-page.html <https://tomee-preview.s3-us-west-2.amazonaws.com/common/home-page.html>

Thanks!
David Jencks

> On Jul 27, 2020, at 7:11 PM, Willes Reis <wi...@gmail.com> wrote:
> 
> Inline...
> 
> Em seg., 27 de jul. de 2020 às 13:56, David Jencks <da...@gmail.com>
> escreveu:
> 
>> Hi Willes,
>> 
>> I think the simplest thing to do for now would be for you to have a GitHub
>> fork of my project and push your branch to it, and open a PR.  There might
>> be better solutions but I don’t know how to make them work :-)
>> 
> I did the GitHub fork to me and already created the PR for your project.
> No problem, let's follow in this way, through GitHub PRs.
> 
> I think this is a good idea.  I think I may have written something
>> misleading or wrong above about git worktrees; Antora doesn’t recognize
>> them other than the main checkout.  Therefore I think the playbook will
>> need to have a path to the local checkout of tomEE but list the 3 or 4
>> branches; the one you happen to be working on currently will have to be
>> renamed “HEAD”.  Alternatively we could expect 3 or 4 complete checkouts of
>> TomEE, but I think that will be too hard to work with.
>> 
>> I hope I’ve written this in a way you can understand :-)
>> 
>> David Jencks
>> 
> Yes, I understood. I tested the "dev-build" with the local-playbook
> targeting the HEAD branch and works well, i.e. the changes reflect in the
> build/site folder to preview statically.
> Of course, before we decide anything, we need to decide where we'll keep
> our "repository for docs and examples".
> 
> Willes

Re: Making Antora actionable

[Willes Reis <wi...@gmail.com>]

No problem... it's your time.
That is great!
I will go synchronize my branches.

Em sáb., 1 de ago. de 2020 às 15:01, David Jencks <da...@gmail.com>
escreveu:

> Sorry for the delay…. I love it!
>
> I merged your PR to master and also rebased the home-page branch on it, I
> hope this doesn’t cause a lot of problems.
>
> The preview is here, including my home-page work:
> https://tomee-preview.s3-us-west-2.amazonaws.com/common/home-page.html <
> https://tomee-preview.s3-us-west-2.amazonaws.com/common/home-page.html>
>
> Thanks!
> David Jencks
>
> > On Jul 27, 2020, at 7:11 PM, Willes Reis <wi...@gmail.com> wrote:
> >
> > Inline...
> >
> > Em seg., 27 de jul. de 2020 às 13:56, David Jencks <
> david.a.jencks@gmail.com>
> > escreveu:
> >
> >> Hi Willes,
> >>
> >> I think the simplest thing to do for now would be for you to have a
> GitHub
> >> fork of my project and push your branch to it, and open a PR.  There
> might
> >> be better solutions but I don’t know how to make them work :-)
> >>
> > I did the GitHub fork to me and already created the PR for your project.
> > No problem, let's follow in this way, through GitHub PRs.
> >
> > I think this is a good idea.  I think I may have written something
> >> misleading or wrong above about git worktrees; Antora doesn’t recognize
> >> them other than the main checkout.  Therefore I think the playbook will
> >> need to have a path to the local checkout of tomEE but list the 3 or 4
> >> branches; the one you happen to be working on currently will have to be
> >> renamed “HEAD”.  Alternatively we could expect 3 or 4 complete
> checkouts of
> >> TomEE, but I think that will be too hard to work with.
> >>
> >> I hope I’ve written this in a way you can understand :-)
> >>
> >> David Jencks
> >>
> > Yes, I understood. I tested the "dev-build" with the local-playbook
> > targeting the HEAD branch and works well, i.e. the changes reflect in the
> > build/site folder to preview statically.
> > Of course, before we decide anything, we need to decide where we'll keep
> > our "repository for docs and examples".
> >
> > Willes
>
>