You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/04/26 00:16:05 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #491: PHOENIX-5168 IndexScrutinyTool to output to Table when that option is…

swaroopak commented on a change in pull request #491: PHOENIX-5168 IndexScrutinyTool to output to Table when that option is…
URL: https://github.com/apache/phoenix/pull/491#discussion_r278774544
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolIT.java
 ##########
 @@ -172,6 +173,14 @@
         protected long getCounterValue(Counters counters, Enum<PhoenixScrutinyJobCounters> counter) {
             return counters.findCounter(counter).getValue();
         }
+
+        protected int countRows(Connection conn, String tableFullName) throws SQLException {
+            ResultSet count = conn.createStatement().executeQuery("select count(*) from " + tableFullName);
 
 Review comment:
   Curious: what happens if the count is way too large?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services