You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@pig.apache.org by Dmitriy Ryaboy <dv...@gmail.com> on 2010/03/01 23:33:45 UTC
User opinions needed
Hi everyone,
I posted a patch that adds a few common String functions to the piggybank
(things like Length and Split). Alan and I are discussing some naming and
design issues, would appreciate your feedback. The main point on which we
are not sure is whether things like Split() should return a tuple or a bag.
Opinions? Please comment here or on the ticket:
https://issues.apache.org/jira/browse/PIG-1248
Thanks,
Dmitriy
Re: User opinions needed
Posted by Dmitriy Ryaboy <dv...@gmail.com>.
I kid, I kid...
On Thu, Mar 4, 2010 at 10:34 AM, Alan Gates <ga...@yahoo-inc.com> wrote:
>
> On Mar 4, 2010, at 10:19 AM, Dmitriy Ryaboy wrote:
>
> Thanks to Gerrit and Bill who responded.
>> Unfortunately they said the exact opposite thing so we are still at an
>> impasse :-). Anyone else care to venture an opinion?
>> Cause if Alan and I have a commiter fight, he'll win and y'all will have
>> to
>> live with unordered split results :)
>>
>
> First, a point of principle. We're both committers and we have equal
> votes. I have no authority that says I win when we disagree. The Apache
> way is that we come to agreement, either by one truly convincing the other
> or some compromise between the two.
>
> Second, sorry if I was unclear, but I don't actually care whether it
> returns bags or tuples. I was just trying to draw out the advantages and
> disadvantages of each to make sure we do what people want. (In contrast to
> the capitalization, where I do care.)
>
> After thinking about it some I think we should pick whichever you believe
> to be the more useful case, and then write functions to convert between bags
> and tuples so that users could use these together with your functions to get
> to whichever they wanted. I've started work on a patch with such functions.
>
> Alan.
>
>
>
>> -D
>>
>> On Mon, Mar 1, 2010 at 2:33 PM, Dmitriy Ryaboy <dv...@gmail.com>
>> wrote:
>>
>> Hi everyone,
>>> I posted a patch that adds a few common String functions to the piggybank
>>> (things like Length and Split). Alan and I are discussing some naming and
>>> design issues, would appreciate your feedback. The main point on which we
>>> are not sure is whether things like Split() should return a tuple or a
>>> bag.
>>> Opinions? Please comment here or on the ticket:
>>> https://issues.apache.org/jira/browse/PIG-1248
>>>
>>> Thanks,
>>> Dmitriy
>>>
>>>
>
Re: User opinions needed
Posted by Alan Gates <ga...@yahoo-inc.com>.
On Mar 4, 2010, at 10:19 AM, Dmitriy Ryaboy wrote:
> Thanks to Gerrit and Bill who responded.
> Unfortunately they said the exact opposite thing so we are still at an
> impasse :-). Anyone else care to venture an opinion?
> Cause if Alan and I have a commiter fight, he'll win and y'all will
> have to
> live with unordered split results :)
First, a point of principle. We're both committers and we have equal
votes. I have no authority that says I win when we disagree. The
Apache way is that we come to agreement, either by one truly
convincing the other or some compromise between the two.
Second, sorry if I was unclear, but I don't actually care whether it
returns bags or tuples. I was just trying to draw out the advantages
and disadvantages of each to make sure we do what people want. (In
contrast to the capitalization, where I do care.)
After thinking about it some I think we should pick whichever you
believe to be the more useful case, and then write functions to
convert between bags and tuples so that users could use these together
with your functions to get to whichever they wanted. I've started
work on a patch with such functions.
Alan.
>
> -D
>
> On Mon, Mar 1, 2010 at 2:33 PM, Dmitriy Ryaboy <dv...@gmail.com>
> wrote:
>
>> Hi everyone,
>> I posted a patch that adds a few common String functions to the
>> piggybank
>> (things like Length and Split). Alan and I are discussing some
>> naming and
>> design issues, would appreciate your feedback. The main point on
>> which we
>> are not sure is whether things like Split() should return a tuple
>> or a bag.
>> Opinions? Please comment here or on the ticket:
>> https://issues.apache.org/jira/browse/PIG-1248
>>
>> Thanks,
>> Dmitriy
>>
Re: User opinions needed
Posted by Dmitriy Ryaboy <dv...@gmail.com>.
Thanks to Gerrit and Bill who responded.
Unfortunately they said the exact opposite thing so we are still at an
impasse :-). Anyone else care to venture an opinion?
Cause if Alan and I have a commiter fight, he'll win and y'all will have to
live with unordered split results :)
-D
On Mon, Mar 1, 2010 at 2:33 PM, Dmitriy Ryaboy <dv...@gmail.com> wrote:
> Hi everyone,
> I posted a patch that adds a few common String functions to the piggybank
> (things like Length and Split). Alan and I are discussing some naming and
> design issues, would appreciate your feedback. The main point on which we
> are not sure is whether things like Split() should return a tuple or a bag.
> Opinions? Please comment here or on the ticket:
> https://issues.apache.org/jira/browse/PIG-1248
>
> Thanks,
> Dmitriy
>