You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/09/26 03:29:25 UTC
[PR] [SPARK-53729][PYTHON][CONNECT] Fix serialization of `pyspark.sql.connect.window.WindowSpec` [spark]
zhengruifeng opened a new pull request, #52464:
URL: https://github.com/apache/spark/pull/52464
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Fix serialization of `pyspark.sql.connect.window.WindowSpec`
### Why are the changes needed?
this query fails
```
from pyspark.sql import Window, WindowSpec
from pyspark.sql.functions import *
df = ( spark.readStream.format("rate-micro-batch")
.option("rowsPerBatch", 1000)
.option("numPartitions", 2)
.load()
.withColumn("some_string",lit("apples")) )
window_spec = Window.partitionBy("some_string").orderBy("value")
def get_calculate_row_number_in_batch(window_spec):
def calculate_row_number_in_batch(df, batch_id):
df.withColumn("row_number", row_number().over(window_spec)).show()
return calculate_row_number_in_batch
(df.writeStream
.queryName('streaming_query')
.foreachBatch(get_calculate_row_number_in_batch(window_spec))
.trigger(processingTime='30 seconds')
.start()
)
```
due to
```
TypeError: WindowSpec.__new__() missing 3 required positional arguments: 'partitionSpec', 'orderSpec', and 'frame'
```
### Does this PR introduce _any_ user-facing change?
bug-fix
### How was this patch tested?
added test, and also manually checked above-mentioned query
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53729][PYTHON][CONNECT] Fix serialization of `pyspark.sql.connect.window.WindowSpec` [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #52464:
URL: https://github.com/apache/spark/pull/52464#discussion_r2380904094
##########
python/pyspark/sql/connect/window.py:
##########
@@ -69,6 +69,9 @@ def __new__(
self.__init__(partitionSpec, orderSpec, frame) # type: ignore[misc]
return self
+ def __getnewargs__(self):
Review Comment:
Just curious, what is the default implementation of this so that the query has failed when we didn't implement this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53729][PYTHON][CONNECT] Fix serialization of `pyspark.sql.connect.window.WindowSpec` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #52464:
URL: https://github.com/apache/spark/pull/52464#discussion_r2381079343
##########
python/pyspark/sql/connect/window.py:
##########
@@ -69,6 +69,9 @@ def __new__(
self.__init__(partitionSpec, orderSpec, frame) # type: ignore[misc]
return self
+ def __getnewargs__(self):
Review Comment:
we have defined the `__new__` for this class,
without the `__getnewargs__`, pickle won't `dumps` the necessary arguments which is needed in `loads`
referring to https://docs.python.org/3/library/pickle.html#pickling-class-instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53729][PYTHON][CONNECT] Fix serialization of `pyspark.sql.connect.window.WindowSpec` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #52464: [SPARK-53729][PYTHON][CONNECT] Fix serialization of `pyspark.sql.connect.window.WindowSpec`
URL: https://github.com/apache/spark/pull/52464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53729][PYTHON][CONNECT] Fix serialization of `pyspark.sql.connect.window.WindowSpec` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #52464:
URL: https://github.com/apache/spark/pull/52464#issuecomment-3337619356
thanks, merged to master and 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org