You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2018/04/25 02:42:00 UTC

[jira] [Updated] (CALCITE-2279) Druid adapter duplicate binary expression

     [ https://issues.apache.org/jira/browse/CALCITE-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Risden updated CALCITE-2279:
----------------------------------
    Summary: Druid adapter duplicate binary expression  (was: Druid adapter duplicates binary expression)

> Druid adapter duplicate binary expression
> -----------------------------------------
>
>                 Key: CALCITE-2279
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2279
>             Project: Calcite
>          Issue Type: Bug
>          Components: druid
>            Reporter: Kevin Risden
>            Priority: Major
>             Fix For: 1.17.0
>
>
> I was looking into Error Prone [1] checking for Calcite and it found what looks like a bug in Druid Adapter. The output is as follows
>  
> {quote}DruidJsonFilter.java:[324,9] [IdentityBinaryExpression] A binary expression where both operands are the same is usually incorrect; the value of this expression is equivalent to `lhs.getType().getFamily() == SqlTypeFamily.NUMERIC`.
> [ERROR]     (see [http://errorprone.info/bugpattern/IdentityBinaryExpression]){quote}
>  
> The DruidJsonFilter [2] has left and right hand the exact same.
>  
> [1] [http://errorprone.info/]
> [2] [https://github.com/apache/calcite/blob/master/druid/src/main/java/org/apache/calcite/adapter/druid/DruidJsonFilter.java#L323]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)