You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/04/27 18:39:47 UTC

[GitHub] [struts] lukaszlenart opened a new pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

lukaszlenart opened a new pull request #410:
URL: https://github.com/apache/struts/pull/410


   Refs https://github.com/apache/struts/pull/405
   Refs [WW-5065](https://issues.apache.org/jira/browse/WW-5065)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls edited a comment on pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #410:
URL: https://github.com/apache/struts/pull/410#issuecomment-620171962


   
   [![Coverage Status](https://coveralls.io/builds/30390878/badge)](https://coveralls.io/builds/30390878)
   
   Coverage increased (+0.01%) to 49.195% when pulling **082d289fa18b9261875c2d4e8a51743bdef9696b on WW-5065-append-or-not-cherry-pick** into **387c203c091c4f92793f8302a392aae749ab5640 on master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] davelnewton commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
davelnewton commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416071496



##########
File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##########
@@ -192,7 +217,7 @@ protected String convertParam(String val, Map<String, String> vars) {
             c = val.charAt(x);
             if (x < len - 2 && 
                     c == '{' && '}' == val.charAt(x+2)) {
-                varVal = (String)vars.get(String.valueOf(val.charAt(x + 1)));
+                varVal = vars.get(String.valueOf(val.charAt(x + 1)));

Review comment:
       (NON-BLOCKER) Never thought about it or ran in to it, but do we throw a startup message or error if it's something *other* than 0-9 or has a spurious `{42}` or `{42` or is that just considered part of a valid, if silly, path?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r419095491



##########
File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##########
@@ -192,7 +217,7 @@ protected String convertParam(String val, Map<String, String> vars) {
             c = val.charAt(x);
             if (x < len - 2 && 
                     c == '{' && '}' == val.charAt(x+2)) {
-                varVal = (String)vars.get(String.valueOf(val.charAt(x + 1)));
+                varVal = vars.get(String.valueOf(val.charAt(x + 1)));

Review comment:
       https://issues.apache.org/jira/browse/WW-5073




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416335442



##########
File path: core/src/main/java/com/opensymphony/xwork2/config/impl/AbstractMatcher.java
##########
@@ -192,7 +217,7 @@ protected String convertParam(String val, Map<String, String> vars) {
             c = val.charAt(x);
             if (x < len - 2 && 
                     c == '{' && '}' == val.charAt(x+2)) {
-                varVal = (String)vars.get(String.valueOf(val.charAt(x + 1)));
+                varVal = vars.get(String.valueOf(val.charAt(x + 1)));

Review comment:
       Hm... good point, I think we can extract `OgnlTextParser` logic and reuse it here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] coveralls commented on pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #410:
URL: https://github.com/apache/struts/pull/410#issuecomment-620171962


   
   [![Coverage Status](https://coveralls.io/builds/30379383/badge)](https://coveralls.io/builds/30379383)
   
   Coverage increased (+0.01%) to 49.195% when pulling **d960e94820eaca17ae72d7d8e58a47fa1486072c on WW-5065-append-or-not-cherry-pick** into **387c203c091c4f92793f8302a392aae749ab5640 on master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] davelnewton commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
davelnewton commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416066319



##########
File path: core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
##########
@@ -107,6 +107,7 @@
 import com.opensymphony.xwork2.validator.DefaultValidatorFileParser;
 import com.opensymphony.xwork2.validator.ValidatorFactory;
 import com.opensymphony.xwork2.validator.ValidatorFileParser;
+import com.sun.org.apache.xpath.internal.operations.Bool;

Review comment:
       Seems spurious




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart commented on a change in pull request #410: [WW-5065] Defines a new flag to control appending params - cherry-pick

Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #410:
URL: https://github.com/apache/struts/pull/410#discussion_r416333380



##########
File path: core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java
##########
@@ -107,6 +107,7 @@
 import com.opensymphony.xwork2.validator.DefaultValidatorFileParser;
 import com.opensymphony.xwork2.validator.ValidatorFactory;
 import com.opensymphony.xwork2.validator.ValidatorFileParser;
+import com.sun.org.apache.xpath.internal.operations.Bool;

Review comment:
       👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org