You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/02/24 13:27:35 UTC

[GitHub] [tinkerpop] FlorianHockmann commented on a change in pull request #1250: fix for https://issues.apache.org/jira/browse/TINKERPOP-2192

FlorianHockmann commented on a change in pull request #1250: fix for https://issues.apache.org/jira/browse/TINKERPOP-2192
URL: https://github.com/apache/tinkerpop/pull/1250#discussion_r383262777
 
 

 ##########
 File path: gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionPool.cs
 ##########
 @@ -131,7 +131,15 @@ private Connection TryGetAvailableConnection(Connection[] connections)
                 }
                 return connection;
             }
-            throw new ConnectionPoolBusyException(_poolSize, _maxInProcessPerConnection);
+
+            if (connections.Length > 0) 
 
 Review comment:
   This improvement definitely also makes sense, but it is not really related to TINKERPOP-2192. So, could you please create a different PR and ideally an issue in JIRA for this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services