[GitHub] [spark] amaliujia commented on a change in pull request #35352: [SPARK-38063][SQL] Support split_part Function

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r797181970



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
##########
@@ -657,4 +657,30 @@ class StringFunctionsSuite extends QueryTest with SharedSparkSession {
     }.getMessage
     assert(m.contains("data type mismatch: argument 1 requires string type"))
   }
+
+  test("SPARK-38063: string split_part function") {

Review comment:
       done. There is only one case that throws exception/errors, which is index as 0 (thus throws ArrayIndexOutOfBoundsException).
   
   If any input is null, or index is out of range (except 0), it returns null.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org