You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/30 13:23:27 UTC
[GitHub] [flink] hequn8128 opened a new pull request #11566:
[FLINK-16673][python] Support metrics for Python UDTF
hequn8128 opened a new pull request #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566
## What is the purpose of the change
This pull request adds metric support for Python UDTF. Note: Most parts of the code had already been added in the PR of adding support for Python UDF(FLINK-16672) since these code can be reused.
## Brief change log
- Add test for metric registrations for Python UDTF.
- Enable python metric for Python UDTF.
## Verifying this change
This change added tests and can be verified as follows:
- Add tests in test_udtf.py
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (PythonDocs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11566:
[FLINK-16673][python] Support metrics for Python UDTF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566#issuecomment-606006605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156592878",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
}, {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6838",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67a23f92479f099a47ecb2a1e5347839cadadaec Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/156592878) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11566:
[FLINK-16673][python] Support metrics for Python UDTF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566#issuecomment-606006605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156592878",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
}, {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6838",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67a23f92479f099a47ecb2a1e5347839cadadaec Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156592878) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu merged pull request #11566: [FLINK-16673][python]
Support metrics for Python UDTF
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11566: [FLINK-16673][python]
Support metrics for Python UDTF
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566#issuecomment-605998668
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 67a23f92479f099a47ecb2a1e5347839cadadaec (Mon Mar 30 13:27:58 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11566:
[FLINK-16673][python] Support metrics for Python UDTF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566#issuecomment-606006605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/156592878",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
}, {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6838",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67a23f92479f099a47ecb2a1e5347839cadadaec Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/156592878) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6838)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11566: [FLINK-16673][python]
Support metrics for Python UDTF
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11566: [FLINK-16673][python] Support metrics for Python UDTF
URL: https://github.com/apache/flink/pull/11566#issuecomment-606006605
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67a23f92479f099a47ecb2a1e5347839cadadaec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67a23f92479f099a47ecb2a1e5347839cadadaec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services