You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Rogério Pereira Araújo (JIRA)" <de...@myfaces.apache.org> on 2006/06/07 18:34:31 UTC
[jira] Created: (TOMAHAWK-476) Support for HtmlInputDate in
HtmlFocus
Support for HtmlInputDate in HtmlFocus
--------------------------------------
Key: TOMAHAWK-476
URL: http://issues.apache.org/jira/browse/TOMAHAWK-476
Project: MyFaces Tomahawk
Type: Improvement
Reporter: Rogério Pereira Araújo
Priority: Trivial
Fix For: 1.1.4-SNAPSHOT
Can't set the focus in inputDate field since the first input has id inputDateId.day
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-476) Support for HtmlInputDate in
HtmlFocus
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Kienenberger updated TOMAHAWK-476:
---------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Rog,
I've improved your patch and committed it.
I'm going to resolve this issue, but I'd recommend that you revisit the patch.
I'd recommend removing hardcoded references to the classes (use the class name instead of the class) and also only perform the clientid change if the renderer class matches, not just the component class.
> Support for HtmlInputDate in HtmlFocus
> --------------------------------------
>
> Key: TOMAHAWK-476
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-476
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Reporter: Rogério Pereira Araújo
> Priority: Trivial
> Attachments: HtmlFocusRenderer.diff
>
>
> Can't set the focus in inputDate field since the first input has id inputDateId.day
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-476) Support for HtmlInputDate in
HtmlFocus
Posted by "Rogério Pereira Araújo (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOMAHAWK-476?page=all ]
Rogério Pereira Araújo updated TOMAHAWK-476:
--------------------------------------------
Status: Patch Available (was: Open)
> Support for HtmlInputDate in HtmlFocus
> --------------------------------------
>
> Key: TOMAHAWK-476
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-476
> Project: MyFaces Tomahawk
> Type: Improvement
> Reporter: Rogério Pereira Araújo
> Priority: Trivial
> Fix For: 1.1.4-SNAPSHOT
>
> Can't set the focus in inputDate field since the first input has id inputDateId.day
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-476) Support for HtmlInputDate in
HtmlFocus
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485303 ]
Mike Kienenberger commented on TOMAHAWK-476:
--------------------------------------------
Changing patch to this:
-
+ if(targetComponent instanceof org.apache.myfaces.custom.date.HtmlInputDate)
+ clientId += org.apache.myfaces.custom.date.HtmlDateRenderer.ID_DAY_POSTFIX;
+
However, I think you're right in that this should only be done if the renderer for the targetComponent is an instance of org.apache.myfaces.custom.date.HtmlDateRenderer. I'd recommend that you provide a tested patch for thist.
> Support for HtmlInputDate in HtmlFocus
> --------------------------------------
>
> Key: TOMAHAWK-476
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-476
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Reporter: Rogério Pereira Araújo
> Priority: Trivial
> Attachments: HtmlFocusRenderer.diff
>
>
> Can't set the focus in inputDate field since the first input has id inputDateId.day
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.