You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/20 17:37:10 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #20326: Migrate global rules (update in TrafficRule) to the shardingsphere-traffic-distsql module.
yx9o opened a new pull request, #20326:
URL: https://github.com/apache/shardingsphere/pull/20326
For #17423 , migrate global rules (update in TrafficRule) to the shardingsphere-traffic-distsql module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #20326: Migrate global rules (update in TrafficRule) to the shardingsphere-traffic-distsql module.
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #20326:
URL: https://github.com/apache/shardingsphere/pull/20326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20326: Migrate global rules (update in TrafficRule) to the shardingsphere-traffic-distsql module.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20326:
URL: https://github.com/apache/shardingsphere/pull/20326#issuecomment-1221380633
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20326](https://codecov.io/gh/apache/shardingsphere/pull/20326?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f2b5c7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5f77569766088f11c9d023d306be5f2801b07f9e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f77569) will **decrease** coverage by `0.02%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #20326 +/- ##
============================================
- Coverage 60.40% 60.37% -0.03%
Complexity 2438 2438
============================================
Files 3915 3917 +2
Lines 55353 55359 +6
Branches 9410 9411 +1
============================================
- Hits 33437 33425 -12
- Misses 19057 19075 +18
Partials 2859 2859
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9rZXJuZWwvS2VybmVsRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../distsql/handler/convert/TrafficRuleConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2Rpc3RzcWwvaGFuZGxlci9jb252ZXJ0L1RyYWZmaWNSdWxlQ29udmVydGVyLmphdmE=) | `94.44% <ø> (ø)` | |
| [...ql/parser/core/TrafficDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYWZmaWMvZGlzdHNxbC9wYXJzZXIvY29yZS9UcmFmZmljRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `78.72% <0.00%> (-4.61%)` | :arrow_down: |
| [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...l/UpdatableGlobalRuleRALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../distsql/ral/impl/UpdatableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9VcGRhdGFibGVSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...mpl/updatable/AlterTrafficRuleStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC91cGRhdGFibGUvQWx0ZXJUcmFmZmljUnVsZVN0YXRlbWVudEFzc2VydC5qYXZh) | `80.00% <ø> (ø)` | |
| [...pl/updatable/CreateTrafficRuleStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC91cGRhdGFibGUvQ3JlYXRlVHJhZmZpY1J1bGVTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...impl/updatable/DropTrafficRuleStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC91cGRhdGFibGUvRHJvcFRyYWZmaWNSdWxlU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `60.00% <ø> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/20326/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org