[GitHub] [airflow] pabloem commented on a diff in pull request #24980: Support `service_account_email` pipeline option for Dataflow jobs in Python or Go

[GitBox <gi...@apache.org>]

pabloem commented on code in PR #24980:
URL: https://github.com/apache/airflow/pull/24980#discussion_r1000037185


##########
airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -124,7 +124,10 @@ class DataflowConfiguration:
         WaitForRun = wait until job finished and the run job.
         Supported only by:
         :py:class:`~airflow.providers.apache.beam.operators.beam.BeamRunJavaPipelineOperator`
-    :param service_account: Run the job as a specific service account, instead of the default GCE robot.
+    :param service_account: Run the Java job as a specific service account, instead of the default Compute Engine service account.
+        See: https://cloud.google.com/dataflow/docs/reference/pipeline-options#java
+    :param service_account_email: Run the Python or Go job as a specific service account for Python or Go, instead of the default Compute Engine service account.
+        See: https://cloud.google.com/dataflow/docs/reference/pipeline-options#python or https://cloud.google.com/dataflow/docs/reference/pipeline-options#go

Review Comment:
   once again my apologies for missing this - I am not sure about how the API deals with this. If not, I am happy to move forward with the way it is...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org