[GitHub] [superset] eschutho commented on a change in pull request #14252: fix: SHOW FUNCTIONS for Databricks

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #14252:
URL: https://github.com/apache/superset/pull/14252#discussion_r617747282



##########
File path: superset/db_engine_specs/hive.py
##########
@@ -530,7 +534,23 @@ def get_function_names(cls, database: "Database") -> List[str]:
         :param database: The database to get functions for
         :return: A list of function names useable in the database
         """
-        return database.get_df("SHOW FUNCTIONS")["tab_name"].tolist()
+        df = database.get_df("SHOW FUNCTIONS")
+        if cls._show_functions_column in df:
+            return df[cls._show_functions_column].tolist()
+
+        columns = df.columns.values.tolist()
+        logger.error(

Review comment:
       When this function is called in core.py the exceptions are caught and logged there. What's the philosophy in this case? Should we catch/log early or let errors bubble up and be caught in one place?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org