[GitHub] [tinkerpop] rdtr opened pull request #1230: [TINKERPOP-2320] allow pass custom XmlInputFactory when instantiating GraphMLReader

["rdtr (GitHub)" <gi...@apache.org>]

Some provider wants to use XMLInputFactory with more secure configurations. This change makes it possible to pass XMLInputFactory when instantiating GraphMLReader.

I don't add any tests right now, I want to first confirm if this direction is OK. If yes, please suggest any tests that I need to add. Thanks !

[ Full content available at: https://github.com/apache/tinkerpop/pull/1230 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] rdtr commented on issue #1230: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

["rdtr (GitHub)" <gi...@apache.org>]

Sorry, rebasing directly on Github UI seems not a good solution to base onto `tp34`... I will make another PR. Thanks.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1230 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] rdtr commented on pull request #1230: [TINKERPOP-2320] allow pass custom XmlInputFactory when instantiating GraphMLReader

["rdtr (GitHub)" <gi...@apache.org>]

It is wasteful to always instantiate a default inputFactory considering it may not be used. Alternatively I can write in create method like:

```
        public GraphMLReader create() {
            if (this.inputFactory == null) {
                this.inputFactory = XMLInputFactory.newInstance();
            }
            return new GraphMLReader(this);
        }
```

[ Full content available at: https://github.com/apache/tinkerpop/pull/1230 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] rdtr commented on issue #1230: TINKERPOP-2320 allow to pass custom XmlInputFactory when instantiating GraphMLReader

["rdtr (GitHub)" <gi...@apache.org>]

I just created a new PR: https://github.com/apache/tinkerpop/pull/1235
Let's continue the discussion there. Thanks!

[ Full content available at: https://github.com/apache/tinkerpop/pull/1230 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org