You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/30 13:38:33 UTC
[GitHub] [ignite] eadha opened a new pull request #9071: Ignite 14600 1
eadha opened a new pull request #9071:
URL: https://github.com/apache/ignite/pull/9071
SSL connection test for thin client.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9071: Ignite 14600 1
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9071:
URL: https://github.com/apache/ignite/pull/9071#discussion_r623896749
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ssl/ssl_params.py
##########
@@ -27,6 +27,7 @@
DEFAULT_ADMIN_KEYSTORE = 'admin.jks'
DEFAULT_PASSWORD = "123456"
DEFAULT_TRUSTSTORE = "truststore.jks"
+DEFAULT_ROOT = "/opt/"
Review comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9071: ignite-14600 ssl test for thin client
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9071:
URL: https://github.com/apache/ignite/pull/9071#discussion_r629977216
##########
File path: modules/ducktests/tests/ignitetest/services/utils/templates/ignite.xml.j2
##########
@@ -86,6 +86,7 @@
{{ ssl_params_util.ssl_params(config.ssl_params) }}
</property>
{% endif %}
+
Review comment:
Please, revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #9071: IGNITE-14600 SSL test for thin client
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #9071:
URL: https://github.com/apache/ignite/pull/9071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9071: ignite-14600 ssl test for thin client
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9071:
URL: https://github.com/apache/ignite/pull/9071#discussion_r629357414
##########
File path: modules/ducktests/tests/ignitetest/services/utils/templates/thin_client_config.xml.j2
##########
@@ -25,5 +27,18 @@
<value>{{ config.addresses }}</value>
</list>
</property>
+
+ {% if config.ssl_params %}
+ <property name="sslMode" value="REQUIRED"/>
+ <property name="sslClientCertificateKeyStorePath" value="{{ config.ssl_params.key_store_path }}"/>
+ <property name="sslClientCertificateKeyStorePassword" value="{{ config.ssl_params.key_store_password }}"/>
+ <property name="sslTrustCertificateKeyStorePath" value="{{ config.ssl_params.trust_store_path }}"/>
+ <property name="sslTrustCertificateKeyStorePassword" value="{{ config.ssl_params.trust_store_password }}"/>
+ {% endif %}
+ {% if config.user %}
Review comment:
Are we still need this piece of config?
Looks like it not used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9071: Ignite 14600 1
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9071:
URL: https://github.com/apache/ignite/pull/9071#discussion_r623890208
##########
File path: modules/ducktests/tests/ignitetest/services/utils/templates/ignite.xml.j2
##########
@@ -96,7 +97,7 @@
<property name="clientConnectorConfiguration">
<bean class="org.apache.ignite.configuration.ClientConnectorConfiguration">
<property name="port" value="{{ config.client_connector_configuration.port }}"/>
- {% if config.client_connector_configuration.ssl_enabled %}
+ {% if config.client_connector_configuration.ssl_enabled or config.ssl_params %}
Review comment:
> `or config.ssl_params`
This seems as wrong condition.
You don't work with this object in condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9071: Ignite 14600 1
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9071:
URL: https://github.com/apache/ignite/pull/9071#discussion_r623890490
##########
File path: modules/ducktests/tests/ignitetest/tests/thin_client_test.py
##########
@@ -32,6 +32,9 @@ class ThinClientTest(IgniteTest):
"""
cluster - cluster size.
JAVA_CLIENT_CLASS_NAME - running classname.
+ to use with ssl enabled:
+ export GLOBALS='{"ssl":{"enabled":true}}'
+ or globals should be provided to jenkins job.
Review comment:
What jenkins job do you have in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9071: Ignite 14600 1
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9071:
URL: https://github.com/apache/ignite/pull/9071#discussion_r623899725
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_configuration/__init__.py
##########
@@ -30,6 +30,9 @@
IGNITE_SERVER_ALIAS
from ignitetest.utils.version import IgniteVersion, DEV_BRANCH
+DEFAULT_USER = "client"
Review comment:
Where do we configure this data on the server node?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org