You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2024/03/02 14:59:27 UTC
[PR] build: Support cross build ci pipelines for Spark 3.2, 3.3 and 3.4 [arrow-datafusion-comet]
advancedxy opened a new pull request, #153:
URL: https://github.com/apache/arrow-datafusion-comet/pull/153
## Which issue does this PR close?
Closes #143.
## Rationale for this change
Software quality and makes sure we don't introduce breaking code that breaks lower Spark versions.
## What changes are included in this PR?
1. fix compile and test failures for old Spark versions
2. modify PR_BUILD.yml to add build and test against Spark 3.2 and 3.3
## How are these changes tested?
CI runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: Support CI pipelines for Spark 3.2, 3.3 and 3.4 [arrow-datafusion-comet]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao merged PR #153:
URL: https://github.com/apache/arrow-datafusion-comet/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: Support CI pipelines for Spark 3.2, 3.3 and 3.4 [arrow-datafusion-comet]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on PR #153:
URL: https://github.com/apache/arrow-datafusion-comet/pull/153#issuecomment-1975052894
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: Support cross build ci pipelines for Spark 3.2, 3.3 and 3.4 [arrow-datafusion-comet]
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #153:
URL: https://github.com/apache/arrow-datafusion-comet/pull/153#discussion_r1509989272
##########
.github/workflows/pr_build.yml:
##########
@@ -44,13 +44,14 @@ jobs:
os: [ubuntu-latest]
java_version: [8, 11, 17]
test-target: [rust, java]
+ spark-version: ['3.4']
is_push_event:
- ${{ github.event_name == 'push' }}
exclude: # exclude java 11 for pull_request event
- java_version: 11
is_push_event: false
fail-fast: false
- name: ${{ matrix.test-target }} test on ${{ matrix.os }} with java ${{ matrix.java_version }}
+ name: ${{ matrix.os }}/java ${{ matrix.java_version }}-spark-${{matrix.spark-version}}/${{ matrix.test-target }}
Review Comment:
Make it shorter to display the whole lines so that it would be clear.
<img width="323" alt="image" src="https://github.com/apache/arrow-datafusion-comet/assets/807537/0fe90af7-5e54-4088-b145-ba547fe50654">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: Support cross build ci pipelines for Spark 3.2, 3.3 and 3.4 [arrow-datafusion-comet]
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #153:
URL: https://github.com/apache/arrow-datafusion-comet/pull/153#issuecomment-1974823572
cc @sunchao @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org