You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/01 12:06:55 UTC

[GitHub] [cloudstack] nvazquez opened a new pull request #4738: Fix VMware OVF properties copy from template

nvazquez opened a new pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738


   ### Description
   
   For backward compatibility, prior to Vmware 6.5 use EDIT operation instead of ADD when copying template vApp information 
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-811695522


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787909003


   @nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805569388


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817084175


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805746930


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817086412


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805575955


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787923622


   Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2847


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-814028741


   @blueorangutan test centos7 vmware-60u2
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816718775


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815227531


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815256092


   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787908500


   @blueorangutan help


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815536346


   <b>Trillian test result (tid-378)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38130 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t378-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Failure` | 89.37 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 83.88 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 70.65 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 66.41 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 67.43 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 66.48 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 66.39 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 65.31 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 103.51 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 43.53 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-811714745


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816433951


   @blueorangutan test centos7 vmware-67u3 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817053508


   <b>Trillian test result (tid-398)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39249 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t398-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.13 | test_diagnostics.py
   test_01_vapps_vm_cycle | `Error` | 0.01 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-788435664


   <b>Trillian test result (tid-3627)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40372 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t3627-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_3d_gpu_support | `Error` | 143.49 | test_deploy_vgpu_enabled_vm.py
   test_01_deploy_kubernetes_cluster | `Failure` | 117.78 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 120.64 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 113.40 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 103.11 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 110.29 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 101.11 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 114.24 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 108.16 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 328.49 | test_kubernetes_clusters.py
   test_03_migrate_detached_volume | `Error` | 84.54 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 44.18 | test_vm_life_cycle.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815176811


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816718182


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813980371


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787904545


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817172041


   <b>Trillian test result (tid-400)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37884 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t400-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.15 | test_diagnostics.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787923861


   @blueorangutan test centos7 vmware-60u2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] borisstoyanov commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815255886


   @blueorangutan test centos7 vmware-60u2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-814011412


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 338


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-811695938


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-814029006


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817772218


   Lgtm! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-796536406


   @blueorangutan test centos7 vmware-60u2
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815226884


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815252413


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817084115


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813980740


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] borisstoyanov commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-795176555


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-806482456


   <b>Trillian test result (tid-254)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48954 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t254-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 81 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 74.11 | test_kubernetes_clusters.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 305.71 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 304.79 | test_routers_network_ops.py
   test_01_migrate_VM_and_root_volume | `Error` | 66.37 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 51.23 | test_vm_life_cycle.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 491.50 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 478.79 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 463.77 | test_vpc_redundant.py
   test_hostha_kvm_host_fencing | `Error` | 658.34 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817078455


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-814474557


   <b>Trillian test result (tid-363)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39167 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t363-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Failure` | 95.02 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 98.40 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 85.96 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 83.76 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 76.67 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 67.40 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 65.34 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 77.58 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 116.73 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 52.66 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-795177452


   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805746859


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787948587


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813235149


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787924468


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-817769280


   @rhtyd can you give this PR a final review? Test fixes added after your review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787903835


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813279507


   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-797058004


   <b>[S] Trillian test result (tid-78)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47517 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t78-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.27 | test_diagnostics.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 800.70 | test_kubernetes_clusters.py
   test_03_migrate_detached_volume | `Error` | 78.55 | test_vm_life_cycle.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 50.50 | test_vm_life_cycle.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787974380


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2848


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816302785


   <b>Trillian test result (tid-384)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47353 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t384-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Failure` | 85.12 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 79.77 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 74.68 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 65.38 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 63.43 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 65.36 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 69.51 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 69.40 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 107.50 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 49.55 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815176293


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813234961


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816733835


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 376


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816797384


   <b>Trillian test result (tid-388)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35738 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t388-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Failure` | 81.44 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 96.27 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 56.45 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 58.36 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 57.41 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 59.40 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 57.41 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 62.03 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 107.23 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 44.64 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-796536833


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has been kicked to run smoke tests [S]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805569947


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-795208219


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 72


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805746708


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#discussion_r597542791



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2725,16 +2729,19 @@ private String getPropertyValue(OVFPropertyTO prop) {
      */
     protected void setVAppPropertiesToConfigSpec(VmConfigInfo vAppConfig,
                                                  Map<String, String> ovfProperties,
-                                                 VirtualMachineConfigSpec vmConfig) throws Exception {
+                                                 VirtualMachineConfigSpec vmConfig, VmwareHypervisorHost hyperHost) throws Exception {
         VmConfigSpec vmConfigSpec = new VmConfigSpec();
         vmConfigSpec.getEula().addAll(vAppConfig.getEula());
         vmConfigSpec.setInstallBootStopDelay(vAppConfig.getInstallBootStopDelay());
         vmConfigSpec.setInstallBootRequired(vAppConfig.isInstallBootRequired());
         vmConfigSpec.setIpAssignment(vAppConfig.getIpAssignment());
         vmConfigSpec.getOvfEnvironmentTransport().addAll(vAppConfig.getOvfEnvironmentTransport());
-        vmConfigSpec.getProduct().addAll(copyVAppConfigProductSectionFromOVF(vAppConfig));
-        vmConfigSpec.getProperty().addAll(copyVAppConfigPropertySectionFromOVF(vAppConfig, ovfProperties));
-        vmConfigSpec.getOvfSection().addAll(copyVAppConfigOvfSectionFromOVF(vAppConfig));
+
+        // For backward compatibility, prior to Vmware 6.5 use EDIT operation instead of ADD
+        boolean useEditOperation = hyperHost.getContext().getServiceContent().getAbout().getApiVersion().compareTo("6.5") < 1;

Review comment:
       
   ```suggestion
           boolean useEditOperation = ((HostMO) hyperHost).getHostAboutInfo().getApiVersion().compareTo("6.5") < 1;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805773655


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-787949208


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813262110


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-815222603


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-812738085


   <b>Trillian test result (tid-334)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34391 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t334-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.20 | test_diagnostics.py
   test_01_deploy_kubernetes_cluster | `Failure` | 80.25 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 50.29 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 78.76 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 53.26 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 53.21 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 56.24 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 56.20 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 52.15 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 90.45 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 47.48 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-801707305


   @nvazquez can you see the vapp failure? cc @borisstoyanov 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#discussion_r597540666



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2707,13 +2710,14 @@ private String getPropertyValue(OVFPropertyTO prop) {
     /**
      * Set the product section spec from existing vApp configuration
      */
-    protected List<VAppProductSpec> copyVAppConfigProductSectionFromOVF(VmConfigInfo vAppConfig) {
+    protected List<VAppProductSpec> copyVAppConfigProductSectionFromOVF(VmConfigInfo vAppConfig, boolean useEdit) {
         List<VAppProductInfo> productFromOvf = vAppConfig.getProduct();
         List<VAppProductSpec> specs = new ArrayList<>();
         for (VAppProductInfo info : productFromOvf) {
             VAppProductSpec spec = new VAppProductSpec();
             spec.setInfo(info);
-            spec.setOperation(ArrayUpdateOperation.ADD);
+            s_logger.info("Procuct info KEY " + info.getKey());

Review comment:
       Product - typo




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-816434227


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] borisstoyanov commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813279150


   @blueorangutan test centos7 vmware-60u2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813639173


   <b>Trillian test result (tid-348)</b>
   Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42133 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4738-t348-vmware-60u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 82 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.22 | test_diagnostics.py
   test_01_deploy_kubernetes_cluster | `Failure` | 99.58 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 83.88 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 76.64 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 68.52 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 78.72 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 67.40 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 66.39 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 68.47 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 105.64 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 44.52 | test_vm_life_cycle.py
   test_10_list_volumes | `Failure` | 366.20 | test_volumes.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-805566256


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] borisstoyanov commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-813858499


   
   ContextSuite context=TestVAppsVM>:setup | Error | 44.52 | test_vm_life_cycle.py
   -- | -- | -- | --
   
   
   This seems like marvin related failure, it's basically failing to setup the test. @nvazquez can you have a look pls


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4738: Fix VMware OVF properties copy from template

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4738:
URL: https://github.com/apache/cloudstack/pull/4738#issuecomment-795216314


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2894


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org