You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "smiklosovic (via GitHub)" <gi...@apache.org> on 2023/06/18 09:35:08 UTC
[GitHub] [cassandra-dtest] smiklosovic opened a new pull request, #221: aligned test with CASSANDRA-18555
smiklosovic opened a new pull request, #221:
URL: https://github.com/apache/cassandra-dtest/pull/221
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1233239685
##########
topology_test.py:
##########
@@ -476,6 +478,8 @@ def test_stop_decommission_too_few_replicas_multi_dc(self):
@jira_ticket CASSANDRA-12510
@expected_errors ToolError when # nodes will drop below configured replicas in NTS/SimpleStrategy
"""
+ self.fixture_dtest_setup.ignore_log_patterns = (r'.*Not enough live nodes to maintain replication factor*')
Review Comment:
We need to ignore this in logs, it is a legitimate log to skip as we are testing this scenario but without it, the node would stop suddenly because internal scanning of the logs by dtest framework would falsely evaluated that node to be eligible for termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235384963
##########
.gitignore:
##########
@@ -11,3 +11,8 @@ upgrade
html/
doxygen/doxypy-0.4.2/
.pytest_cache/
+
+bin/
Review Comment:
@driftx there are activation scripts for python env and similar
$ ls bin/
activate activate.csh activate.fish activate.nu activate.ps1 activate_this.py ccm pip pip3 pip-3.10 pip3.10 python
python3 python3.10 wheel wheel3 wheel-3.10 wheel3.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1233239443
##########
topology_test.py:
##########
@@ -443,6 +443,8 @@ def test_crash_during_decommission(self):
cluster.populate(3).start()
node1, node2 = cluster.nodelist()[0:2]
+ session = self.patient_cql_connection(node1)
+ session.execute("ALTER KEYSPACE system_distributed WITH REPLICATION = {'class':'SimpleStrategy', 'replication_factor':'2'};")
Review Comment:
this is in other test methods too, without this, we are actually not decommissioning anything because decommission will fail as there will not be enough replicas if replication factor will be 3 and we want to decommission to have just 2. We need to lower this to 2 so by decommissioning we will have still enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1233239685
##########
topology_test.py:
##########
@@ -476,6 +478,8 @@ def test_stop_decommission_too_few_replicas_multi_dc(self):
@jira_ticket CASSANDRA-12510
@expected_errors ToolError when # nodes will drop below configured replicas in NTS/SimpleStrategy
"""
+ self.fixture_dtest_setup.ignore_log_patterns = (r'.*Not enough live nodes to maintain replication factor*')
Review Comment:
We need to ignore this in logs, it is a legitimate log to skip as we are testing this scenario but without it, the node would stop suddenly because internal scanning of the logs by dtest framework would falsely evaluate that node to be eligible for termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235396299
##########
topology_test.py:
##########
@@ -476,6 +478,8 @@ def test_stop_decommission_too_few_replicas_multi_dc(self):
@jira_ticket CASSANDRA-12510
@expected_errors ToolError when # nodes will drop below configured replicas in NTS/SimpleStrategy
"""
+ self.fixture_dtest_setup.ignore_log_patterns = (r'.*Not enough live nodes to maintain replication factor*')
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] driftx commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "driftx (via GitHub)" <gi...@apache.org>.
driftx commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235387001
##########
.gitignore:
##########
@@ -11,3 +11,8 @@ upgrade
html/
doxygen/doxypy-0.4.2/
.pytest_cache/
+
+bin/
Review Comment:
That sounds like you are making a virutalenv in the current directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] driftx commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "driftx (via GitHub)" <gi...@apache.org>.
driftx commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235352538
##########
.gitignore:
##########
@@ -11,3 +11,8 @@ upgrade
html/
doxygen/doxypy-0.4.2/
.pytest_cache/
+
+bin/
Review Comment:
where is the bin dir coming from though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235400622
##########
.gitignore:
##########
@@ -11,3 +11,8 @@ upgrade
html/
doxygen/doxypy-0.4.2/
.pytest_cache/
+
+bin/
Review Comment:
privately agreed we can keep it like it is here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] driftx commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "driftx (via GitHub)" <gi...@apache.org>.
driftx commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235355081
##########
topology_test.py:
##########
@@ -476,6 +478,8 @@ def test_stop_decommission_too_few_replicas_multi_dc(self):
@jira_ticket CASSANDRA-12510
@expected_errors ToolError when # nodes will drop below configured replicas in NTS/SimpleStrategy
"""
+ self.fixture_dtest_setup.ignore_log_patterns = (r'.*Not enough live nodes to maintain replication factor*')
Review Comment:
Comments around this would be useful, it's not obvious what we're doing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1235400622
##########
.gitignore:
##########
@@ -11,3 +11,8 @@ upgrade
html/
doxygen/doxypy-0.4.2/
.pytest_cache/
+
+bin/
Review Comment:
offline agreed we can keep it like it is here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] smiklosovic commented on a diff in pull request #221: aligned test with CASSANDRA-18555
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #221:
URL: https://github.com/apache/cassandra-dtest/pull/221#discussion_r1233239137
##########
.gitignore:
##########
@@ -11,3 +11,8 @@ upgrade
html/
doxygen/doxypy-0.4.2/
.pytest_cache/
+
+bin/
Review Comment:
this drives me crazy, this should be in `.gitignore` already for a very long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] aligned test with CASSANDRA-18555 [cassandra-dtest]
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #221: aligned test with CASSANDRA-18555
URL: https://github.com/apache/cassandra-dtest/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org