You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/09 01:25:26 UTC

[GitHub] [airflow] kubatyszko commented on pull request #10256: fixes http hook using schema field from airflow.models.connection.Con…

kubatyszko commented on pull request #10256:
URL: https://github.com/apache/airflow/pull/10256#issuecomment-670992363


   > Can you add unit tests to avoid regression?
   
   I'll try to look at the tests soon, I'd like to wait for the CI runs to complete, it seems that many unrelated ones are failing.
   Also, since my issue is isolated to only secrets backends, and there ARE tests provided, this must mean that the tests are either flawed or incomplete.
   The postgres backend for connection/variables etc is working fine an my code doesn't touch that.
   I may need some guidance with local development and test suite.
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org