[GitHub] yiguolei commented on a change in pull request #350: Optimize the publish logic of streaming load

[GitBox <gi...@apache.org>]

yiguolei commented on a change in pull request #350: Optimize the publish logic of streaming load
URL: https://github.com/apache/incubator-doris/pull/350#discussion_r236201082
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/transaction/TransactionState.java
 ##########
 @@ -321,4 +330,11 @@ public LoadJobSourceType getSourceType() {
     public Map<Long, PublishVersionTask> getPublishVersionTasks() {
         return publishVersionTasks;
     }
+
+    public boolean isPublishTimeout() {
+        // timeout is between 3 to 10 seconds.
+        long timeoutMillis = Math.min(Config.publish_version_timeout_second * publishVersionTasks.size() * 1000, 10000);
 
 Review comment:
   set 10000 to a config, and the minimum value should be 5min

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org