You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by sandeepdeshmukh <gi...@git.apache.org> on 2016/01/29 16:28:23 UTC
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
GitHub user sandeepdeshmukh opened a pull request:
https://github.com/apache/incubator-apex-site/pull/11
APEXCORE-215 #comment Added Apache Apex release candidate verificatio…
…n guidelines.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandeepdeshmukh/incubator-apex-site APEXCORE-215.build-verification-steps
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-site/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit c6eda65a2b80a675d3789c2cdf13229fd37570a5
Author: Sandeep Deshmukh <sa...@datatorrent.com>
Date: 2016-01-29T15:12:25Z
APEXCORE-215 #comment Added Apache Apex release candidate verification guidelines
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r53062507
--- Diff: src/md/verification.md ---
@@ -0,0 +1,88 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .zip source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean apache-rat:check verify -Dlicense.skip=false -Pall-modules verify -Papache-release package
--- End diff --
Is it necessary to have multiple verify and package goal? Will it be sufficient to have only one of them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by bhupeshchawda <gi...@git.apache.org>.
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r51406907
--- Diff: src/md/verification.md ---
@@ -0,0 +1,82 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .tar.gz source
--- End diff --
Using .zip* source
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r53588997
--- Diff: src/md/verification.md ---
@@ -0,0 +1,88 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .zip source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean apache-rat:check verify -Dlicense.skip=false -Pall-modules verify -Papache-release package
+```
+In case of Apex release, you can skip -Papache-release option as there are no modules defined in Apex as of now.
+
+
+## Launch demos
+Launch few demos to make sure everything is working fine using dtcli utitlity. The dtcli script is present at <apex-core-folder>/engine/src/main/scripts/dtcli . If apex-core is being verified, then simply use engine/src/main/scripts/dtcli to launch the script. Otherwise, prefix it with apex-core folder path.
+
+```bash
+engine/src/main/scripts/dtcli
+```
+You will get dtcli prompt, where demos can be launched.
+```bash
+dt> launch <demo-apk-file>
--- End diff --
These are .apa files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by chinmaykolhatkar <gi...@git.apache.org>.
Github user chinmaykolhatkar commented on the pull request:
https://github.com/apache/incubator-apex-site/pull/11#issuecomment-177781884
Can you please add a check for whether there are any binaries in the source:
Following command gives list all file extensions:
/media/chinmay/src/verification/apex-3.3.0-incubating$ find . -type f -name '*.*' | sed 's|.*\.||' | sort -u
Following command gives all the files in folder which are of type binary:
find -type f -executable -exec file -i '{}' \; | grep 'x-executable; charset=binary'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by shubham-pathak22 <gi...@git.apache.org>.
Github user shubham-pathak22 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r51381233
--- Diff: src/md/verification.md ---
@@ -0,0 +1,82 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .tar.gz source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean package
+mvn apache-rat:check verify -Dlicense.skip=false -Pall-modules -DskipTests
+mvn verify -Papache-release -DskipTests
+```
+
+## Launch demos
+Launch few demos to make sure everything is working fine using dtcli utitlity. The dtcli script is present at <apex-core-folder>/engine/src/main/scripts/dtcli . If apex-core is being verified, then simply use engine/src/main/scripts/dtcli to launch the script. Otherwise, prefix it with apex-core folder path.
+
+```bash
+engine/src/main/scripts/dtcli
+```
+You will get dtcli prompt, where demos can be launched.
+```bash
+dt> launch <demo-apk-file>
+```
+Demo apk files are typically in incubating-apex-malhar/demos directory.
+
+## Additional checks
+1. Existence of DISCLAIMER, LICENSE, NOTICE, and CHANGELOG.md files.
+2. No unexpected binary files in the sources.
+3. Presensence of word incubating in the artifact name.
--- End diff --
Presence ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-site/pull/11#issuecomment-183730553
@sandeepdeshmukh can you please address the comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r53427079
--- Diff: src/md/verification.md ---
@@ -0,0 +1,112 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. Download the KEYS file and import it. Verify that the key just imported is correct.
+This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+gpg --fingerprint D920A98C
+```
+More about key verification at [http://www.apache.org/info/verification.html](http://www.apache.org/info/verification.html)
+
+2. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate. It is recommended that these files are downloaded in a clean directory.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .zip source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+Change directory:
+```bash
+cd $APEX_RELEASE_CANDIDATE
+```
+
+### Miscellaneous checks: Part I (Pre Compilation)
+1. Existence of DISCLAIMER, LICENSE, NOTICE, README.md and CHANGELOG.md files.
+Please make sure these files are present in the parent folder after extracting the zip or tar. The CHANGELOG.md file should contain change log for the current release.
+2. No unexpected binary files in the sources.
+The extracted directory should not contain any binary. Need to test this before compiling the source code.
+```bash
+find . -type f -name '*.*' | sed 's|.*\.||' | sort -u
+```
+Please make sure no binary extension is listed here. Likely candidates are .jar files. Additionally, for Malhar, demo package files, i.e. .apa files.
+
+### Check for compilation, license headers, etc.
+
+For Apex:
+```bash
+mvn clean apache-rat:check verify -Dlicense.skip=false install
+```
+For Malhar:
+```bash
+mvn clean apache-rat:check verify -Dlicense.skip=false -Pall-modules install
+```
+Jars should be installed in your maven repository, typically in *~/.m2/repository/org/apache/apex/* directory
+
+Following step is optional and needs prerequisite 2 given above.
+```bash
+mvn verify -Papache-release -DskipTests
+```
+
+## Launch demos
+Launch few demos to make sure everything is working fine using *dtcli* utitlity. The dtcli script is present at <apex-core-folder>/engine/src/main/scripts/dtcli . If apex-core is being verified, then simply use engine/src/main/scripts/dtcli to launch the script. Otherwise, prefix it with apex-core folder path.
+
+```bash
+engine/src/main/scripts/dtcli
+```
+You will get dtcli prompt, where demos can be launched.
+```bash
+dt> launch <demo-apk-file>
+```
+Demo apk files are typically in incubating-apex-malhar/demos directory.
+
+
+## Miscellaneous checks: Part II (Post compilation)
+1. Incubating word in artifact name.
+The artifacts generated by the build should have word incubating in it. For example, apex-common-3.3.0-incubating.jar. It should also contain the right version number.
--- End diff --
IMO this is not valid. Should instead check the source release name and the artifacts in Maven, not in a local build directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by sandeepdeshmukh <gi...@git.apache.org>.
Github user sandeepdeshmukh commented on the pull request:
https://github.com/apache/incubator-apex-site/pull/11#issuecomment-184765671
I will address these comments and update the pull request soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r53063093
--- Diff: src/md/verification.md ---
@@ -0,0 +1,88 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .zip source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean apache-rat:check verify -Dlicense.skip=false -Pall-modules verify -Papache-release package
+```
+In case of Apex release, you can skip -Papache-release option as there are no modules defined in Apex as of now.
--- End diff --
Looks like the intention was to skip all-modules profile, not apache-release profile. It will be better either to mention that the warning regarding missing all-modules profile is ignored or give two different mvn commands - one for core and one for malhar. Most likely they will be copied and paste as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by daemon12 <gi...@git.apache.org>.
Github user daemon12 commented on the pull request:
https://github.com/apache/incubator-apex-site/pull/11#issuecomment-177907589
Updated the command given by @chinmaykolhatkar as asterisk was not handled properly in the comment.
Following command gives list all file extensions:
find . -type f -name '\*.\*' | sed 's|.*\\.||' | sort -u
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-site/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r53426395
--- Diff: src/md/verification.md ---
@@ -0,0 +1,88 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .zip source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean apache-rat:check verify -Dlicense.skip=false -Pall-modules verify -Papache-release package
+```
+In case of Apex release, you can skip -Papache-release option as there are no modules defined in Apex as of now.
+
+
+## Launch demos
+Launch few demos to make sure everything is working fine using dtcli utitlity. The dtcli script is present at <apex-core-folder>/engine/src/main/scripts/dtcli . If apex-core is being verified, then simply use engine/src/main/scripts/dtcli to launch the script. Otherwise, prefix it with apex-core folder path.
+
+```bash
+engine/src/main/scripts/dtcli
+```
+You will get dtcli prompt, where demos can be launched.
+```bash
+dt> launch <demo-apk-file>
--- End diff --
Do you mean launch existing version of demo with new Apex version? If so, then yes. In general, these are recommendations what folks can do the verify a release and not everyone will run through all of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r52832442
--- Diff: src/md/verification.md ---
@@ -0,0 +1,82 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .tar.gz source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean package
+mvn apache-rat:check verify -Dlicense.skip=false -Pall-modules -DskipTests
--- End diff --
-Pall-modules is just a warning, we can add it to the pom as empty profile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-site/pull/11#issuecomment-187028183
Will merge this. Further changes can be made separately. May also want to check formatting overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r51590627
--- Diff: src/md/verification.md ---
@@ -0,0 +1,82 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .tar.gz source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean package
+mvn apache-rat:check verify -Dlicense.skip=false -Pall-modules -DskipTests
--- End diff --
all-module profile is not defined for apex-core.
Why is it necessary to run 3 distinct mvn?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by bhupeshchawda <gi...@git.apache.org>.
Github user bhupeshchawda commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r51406961
--- Diff: src/md/verification.md ---
@@ -0,0 +1,82 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
--- End diff --
http://www.apache.org/info/verification.html mentions additional step for validating authenticity of a key. Should we add this step?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-site pull request: APEXCORE-215 #comment Added Apac...
Posted by chinmaykolhatkar <gi...@git.apache.org>.
Github user chinmaykolhatkar commented on a diff in the pull request:
https://github.com/apache/incubator-apex-site/pull/11#discussion_r53154072
--- Diff: src/md/verification.md ---
@@ -0,0 +1,88 @@
+# How to verify Apache Apex (incubating) release candidate builds
+
+## Prerequisites
+1. *gpg* program should be installed on your system.
+2. Download the KEYS file and import it. This is one time activity.
+```bash
+wget https://dist.apache.org/repos/dist/release/incubator/apex/KEYS
+gpg --import KEYS
+```
+3. You can also created your own key which is required if you would like to sign the build. This step is optional.
+```bash
+gpg --gen-key
+```
+Please provide 4096 as keysize while generating the key.
+
+## File integrity check
+Download all files present in staging directory of the RC build. Staging directory link is shared in VOTE thread of the release candidate.
+
+```bash
+wget -r -np -nd <staging-area-link>/
+```
+Note the link should end with "/".
+
+Define the apex release candidate variable. We will set it up *apex-3.3.0-incubating* as an example.
+```bash
+APEX_RELEASE_CANDIDATE=apex-3.3.0-incubating
+```
+
+Verify integrity of tar.gz file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.tar.gz.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.tar.gz.sha
+```
+
+Verify integrity of .zip file:
+```bash
+gpg --verify $APEX_RELEASE_CANDIDATE-source-release.zip.asc
+md5sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.md5
+sha512sum --check $APEX_RELEASE_CANDIDATE-source-release.zip.sha
+```
+## Source code verification
+You can extract source either using .tar.gz file or .zip file.
+
+### Using .tar.gz source
+Extract source using .tar.gz:
+```bash
+tar -zxvf $APEX_RELEASE_CANDIDATE-source-release.tar.gz
+```
+### Using .zip source
+```bash
+unzip $APEX_RELEASE_CANDIDATE-source-release.zip
+```
+
+Any of the two commands above will create a directory named after *apex release candidate*.
+
+### Check for compilation, license headers, etc.
+
+The last step is optional and needs prerequisite 3 given above.
+```bash
+cd $APEX_RELEASE_CANDIDATE
+mvn clean apache-rat:check verify -Dlicense.skip=false -Pall-modules verify -Papache-release package
+```
+In case of Apex release, you can skip -Papache-release option as there are no modules defined in Apex as of now.
+
+
+## Launch demos
+Launch few demos to make sure everything is working fine using dtcli utitlity. The dtcli script is present at <apex-core-folder>/engine/src/main/scripts/dtcli . If apex-core is being verified, then simply use engine/src/main/scripts/dtcli to launch the script. Otherwise, prefix it with apex-core folder path.
+
+```bash
+engine/src/main/scripts/dtcli
+```
+You will get dtcli prompt, where demos can be launched.
+```bash
+dt> launch <demo-apk-file>
--- End diff --
Should we also add check for launching the demo application with malhar compiled with new apex??
This will take care of backward compatibility while compilation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---