You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/05/11 21:17:07 UTC
[GitHub] [mynewt-core] agross-korg opened a new pull request, #2835: Mbedtls GCM refresh
agross-korg opened a new pull request, #2835:
URL: https://github.com/apache/mynewt-core/pull/2835
This set of changes adds back in a couple of GCM functions that we had been using but which were recently dropped during the mbedtls update.
Specifically these are the mbedtls_gcm_setkey_noalloc() and mbedtls_gcm_update_add() APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] agross-korg merged pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
agross-korg merged PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
sjanc commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1124894555
any chance you could try also send this to mbedtls upstream?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] agross-korg commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
agross-korg commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1125143414
If we do add tests, it needs to be outside of the mbed codebase. But looking at the selftest infrastructure we put in place, all it does is call the mbed internal functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
sjanc commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1124902742
mbedtls_gcm_update_add seems to be available in 3.0, so we will get this as eventually we need to move to 3.x anyway
checking mbedtls_gcm_setkey_noalloc() doesn't give any results in google search for me (other than mynewt)
if nobody is going to pursue upstream for mbedtls_gcm_setkey_noalloc than at least we should have at test that would use mbedtls_gcm_setkey_noalloc() (so 'newt test all' would fail)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
utzig commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1124896975
> > any chance you could try also send this to mbedtls upstream?
>
> Marko sent it back in the day and it was not accepted.
For reference: https://github.com/Mbed-TLS/mbedtls/pull/2583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
utzig commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1125198496
> Can we merge this and then add an issue to add in a specific mbed gcm test for this?
Maybe open a new issue and assign it to yourself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] agross-korg commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
agross-korg commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1125215523
> > Can we merge this and then add an issue to add in a specific mbed gcm test for this?
>
> Maybe open a new issue and assign it to yourself?
Done. I'll put in another PR when I get that resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
utzig commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1124896078
> any chance you could try also send this to mbedtls upstream?
Marko sent it back in the day and it was not accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] agross-korg commented on pull request #2835: Mbedtls GCM refresh
Posted by GitBox <gi...@apache.org>.
agross-korg commented on PR #2835:
URL: https://github.com/apache/mynewt-core/pull/2835#issuecomment-1125144177
Can we merge this and then add an issue to add in a specific mbed gcm test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org