[GitHub] [flink] XComp commented on a diff in pull request #21869: [FLINK-30910][runtime] Making test wait for stop to be called before finishing the bootstrap operation

["XComp (via GitHub)" <gi...@apache.org>]

XComp commented on code in PR #21869:
URL: https://github.com/apache/flink/pull/21869#discussion_r1097446435


##########
flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapTest.java:
##########
@@ -348,6 +350,10 @@ void testApplicationIsStoppedWhenStoppingBootstrap() throws Exception {
 
         bootstrap.stop();
 
+        // the JobStatusFuture needs to be completed after stopping the bootstrap process to ensure
+        // that the process doesn't finish before explicitly stopping it

Review Comment:
   You got me on that one. I mixed up the `applicationExecutionTask` and the `applicationCompletionFuture` and, therefore, also came up with a wrong comment. Initially, I was puzzled why it worked anyway. I updated the comment to reflect the actual reason why this works. PTAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org