You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/06 02:01:42 UTC
[GitHub] [hudi] danny0405 commented on a diff in pull request #7611: [HUDI-5506] StreamWriteOperatorCoordinator may not recommit with partial uncommitted write metadata event
danny0405 commented on code in PR #7611:
URL: https://github.com/apache/hudi/pull/7611#discussion_r1063036901
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -96,9 +97,11 @@ public void close() {
*
* <p>This expects to be called by the driver.
*/
- public void bootstrap() throws IOException {
+ public void bootstrap(HoodieTableMetaClient metaClient) throws IOException {
fs.delete(path, true);
fs.mkdirs(path);
+ TimelineUtils.getBasicCommitTimeline(metaClient).filterPendingExcludingCompaction()
Review Comment:
Yeah, we should use different `CkpMetadata` for different jobs, and we may not clean the metadata at all. Or a better solution is just to keep the old `CkpMetadata` messages. There is no need to clean it actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org