You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilooner <gi...@git.apache.org> on 2015/10/22 19:09:07 UTC
[GitHub] incubator-apex-malhar pull request: - MLHR-1876 #resolve Cleanly t...
GitHub user ilooner opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/66
- MLHR-1876 #resolve Cleanly terminated window bounded service thread…
… and removed unnecessary interrupt of main operator thread.
- Fixed emitting schemas on output port in a different thread.
- Closed connections in WebSocketInput Operator on teardown
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/incubator-apex-malhar MLHR-1876_pull
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit 7371412f11f8bb90e749d777e06e30af1dddca51
Author: Timothy Farkas <ti...@datatorrent.com>
Date: 2015-10-22T04:33:53Z
- MLHR-1876 #resolve Cleanly terminated window bounded service thread and removed unnecessary interrupt of main operator thread.
- Fixed emitting schemas on output port in a different thread.
- Closed connections in WebSocketInput Operator on teardown
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: - MLHR-1876 #resolve Cleanly t...
Posted by ishark <gi...@git.apache.org>.
Github user ishark commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/66#discussion_r42810195
--- Diff: library/src/main/java/com/datatorrent/lib/io/PubSubWebSocketAppDataQuery.java ---
@@ -105,11 +105,11 @@ public void endWindow()
@Override
public void teardown()
{
+ super.teardown();
--- End diff --
Is it needed to be before BoundedService teardown? Shouldn't the teardown of operator be after service termination?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: - MLHR-1876 #resolve Cleanly t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: - MLHR-1876 #resolve Cleanly t...
Posted by ishark <gi...@git.apache.org>.
Github user ishark commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/66#discussion_r42811427
--- Diff: library/src/main/java/com/datatorrent/lib/appdata/query/WindowBoundedService.java ---
@@ -99,17 +100,31 @@ public void endWindow()
@Override
public void teardown()
{
- executorThread.shutdownNow();
+ LOG.info("Shutting down");
+ terminated = true;
+ mutex.release();
+
+ try {
+ executorThread.awaitTermination(10000L + executeIntervalMillis, TimeUnit.MILLISECONDS);
+ } catch (InterruptedException ex) {
+ //Do nothing
+ }
+
+ executorThread.shutdown();
--- End diff --
I think shutdown should be invoked first before awaitTermination.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---